Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30254][SQL] Fix LikeSimplification optimizer to use a given escapeChar #26880

Closed
wants to merge 1 commit into from

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Since 25001, spark support like escape syntax.

We should also sync the escape used by LikeSimplification.

Why are the changes needed?

Avoid optimize failed.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Add UT.

@SparkQA
Copy link

SparkQA commented Dec 13, 2019

Test build #115293 has finished for PR 26880 at commit c701507.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Hi, @ulysses-you and reviewers.
Please hold on this until we finish reverting the following. It's not directly related, but we had better be careful.

@dongjoon-hyun
Copy link
Member

I merged #26883 .

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Dec 14, 2019

Test build #115316 has finished for PR 26880 at commit c701507.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ulysses-you
Copy link
Contributor Author

@dongjoon-hyun thanks for remind this.

Copy link
Member

@maropu maropu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30254][SQL] Fix use custom escape lead to LikeSimplification optimize failed [SPARK-30254][SQL] Fix LikeSimplification optimizer to use a given escapeChar Dec 18, 2019
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.

@dongjoon-hyun
Copy link
Member

Thank you, @ulysses-you .
cc @beliefer , @cloud-fan , @gengliangwang since this is a kind of follow-up of #25001

@gengliangwang
Copy link
Member

Thanks for the work, @ulysses-you

@beliefer
Copy link
Contributor

Thanks @ulysses-you

@ulysses-you
Copy link
Contributor Author

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants