Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[SPARK-30230][SQL] Like ESCAPE syntax can not use '_' and '%'" #26883

Closed
wants to merge 1 commit into from
Closed

Revert "[SPARK-30230][SQL] Like ESCAPE syntax can not use '_' and '%'" #26883

wants to merge 1 commit into from

Conversation

gengliangwang
Copy link
Member

This reverts commit cada5be.

@gengliangwang
Copy link
Member Author

More context in #26860 (comment)

dongjoon-hyun
dongjoon-hyun approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (Thank you for swift reverting, @gengliangwang ).

@dongjoon-hyun dongjoon-hyun mentioned this pull request Dec 13, 2019
Closed
@dongjoon-hyun
Copy link
Member

Merged to master. I tested this locally, too. Thank you!

@SparkQA
Copy link

SparkQA commented Dec 13, 2019

Test build #115314 has finished for PR 26883 at commit f28319b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gengliangwang @dongjoon-hyun @SparkQA