[SPARK-7044] [SQL] Fix the deadlock in script transformation #5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #30728 has finished for PR 5625 at commit
|
| // and keep the collector as remain in the main thread. | ||
| // otherwise it will causes deadlock if the data size greater than | ||
| // the pipeline / buffer capacity. | ||
| future { |
There was a problem hiding this comment.
should we just create a new thread to run this? seems wrong to use a global shared thread pool
There was a problem hiding this comment.
Thank you @rxin, I think you are right, updated!
chenghao-intel
force-pushed
the
transform
branch
from
885685a
to
5ec1dd2
Compare
|
Test build #30847 has finished for PR 5625 at commit
|
|
Merging in master & branch-1.3. |
|
Actually this doesn't merge cleanly into 1.3. Do you mind submitting a pull request for that branch? Thanks. |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 14, 2015
Author: Cheng Hao <hao.cheng@intel.com> Closes apache#5625 from chenghao-intel/transform and squashes the following commits: 5ec1dd2 [Cheng Hao] fix the deadlock issue in ScriptTransform
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
Author: Cheng Hao <hao.cheng@intel.com> Closes apache#5625 from chenghao-intel/transform and squashes the following commits: 5ec1dd2 [Cheng Hao] fix the deadlock issue in ScriptTransform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.