Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-7044][SQL] Fix the deadlock in ScriptTransform(for Spark 1.3) #5671

Closed
wants to merge 1 commit into from

Conversation

chenghao-intel
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Apr 24, 2015

Test build #30891 has started for PR 5671 at commit 2237e81.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Apr 24, 2015

Test build #30891 has finished for PR 5671 at commit 2237e81.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30891/
Test PASSed.

@chenghao-intel
Copy link
Contributor Author

cc @rxin

@rxin
Copy link
Contributor

rxin commented Apr 24, 2015

Thanks. I've merged this.

asfgit pushed a commit that referenced this pull request Apr 24, 2015
Author: Cheng Hao <hao.cheng@intel.com>

Closes #5671 from chenghao-intel/transform2 and squashes the following commits:

2237e81 [Cheng Hao] fix the deadlock in ScriptTransform
@rxin
Copy link
Contributor

rxin commented Apr 24, 2015

Can you close the PR? Since it was not merged into master, github won't close this automatically.

@chenghao-intel
Copy link
Contributor Author

Thank you @rxin, closing since it's merged.

@jfhu
Copy link

jfhu commented May 5, 2015

@chenghao-intel The exact deadlock happens for stderr too, is there a quick fix for that? Thanks!

@chenghao-intel
Copy link
Contributor Author

Thank you @jfhu for reporting this, I will do the updating. And it will be appreciated if you can paste the reproduce steps.

@jfhu
Copy link

jfhu commented May 6, 2015

@chenghao-intel Thanks! re-pro steps: (actually copied and adapted from your patch :)

val data = (1 to 100000).map { i => (i, i, i) }
data.toDF("d1", "d2", "d3").registerTempTable("script_trans")
sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat 1>&2' AS (a,b,c) FROM script_trans").queryExecution.toRdd.count()

asfgit pushed a commit that referenced this pull request Jun 12, 2015
[Related PR SPARK-7044] (#5671)

Author: zhichao.li <zhichao.li@intel.com>

Closes #6404 from zhichao-li/transform and squashes the following commits:

8418c97 [zhichao.li] add comments and remove useless failAfter logic
d9677e1 [zhichao.li] redirect the error desitination to be the same as the current process
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
[Related PR SPARK-7044] (apache#5671)

Author: zhichao.li <zhichao.li@intel.com>

Closes apache#6404 from zhichao-li/transform and squashes the following commits:

8418c97 [zhichao.li] add comments and remove useless failAfter logic
d9677e1 [zhichao.li] redirect the error desitination to be the same as the current process
@chenghao-intel chenghao-intel deleted the transform2 branch July 2, 2015 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants