Skip to content

Commit

Permalink
chore(pylint): Reenable ungrouped-imports check (#16256)
Browse files Browse the repository at this point in the history
Co-authored-by: John Bodley <john.bodley@airbnb.com>
  • Loading branch information
john-bodley and john-bodley committed Aug 16, 2021
1 parent 8e07dd2 commit 7b72443
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ confidence=
disable=
missing-docstring,
too-many-lines,
ungrouped-imports,
import-outside-toplevel,
raise-missing-from,
too-few-public-methods,
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci_check_no_file_changes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ REGEXES=()
for CHECK in "$@"
do
if [[ ${CHECK} == "python" ]]; then
REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt)"
REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt|^\.pylintrc)"
echo "Searching for changes in python files"
elif [[ ${CHECK} == "frontend" ]]; then
REGEX="(^\.github\/workflows\/.*(frontend|e2e)|^superset-frontend\/)"
Expand Down

0 comments on commit 7b72443

Please sign in to comment.