chore(pylint): Reenable ungrouped-imports check #16256
Conversation
john-bodley
force-pushed
the
john-bodley--pylint-reenable-ungrouped-imports
branch
from
32d083c
to
182fbdd
Compare
| @@ -34,7 +34,7 @@ REGEXES=() | |||
| for CHECK in "$@" | |||
| do | |||
| if [[ ${CHECK} == "python" ]]; then | |||
| REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt)" | |||
| REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt|^\.pylintrc)" | |||
There was a problem hiding this comment.
This maybe overkill, i.e., enable all Python checks on only a change to the .pylintrc file, though changes to only the .pylintrc file are rare.
There was a problem hiding this comment.
I agree with this; these are so uncommon doing a bit of overkill here is better than not doing it at all.
Codecov Report
@@ Coverage Diff @@
## master #16256 +/- ##
==========================================
- Coverage 76.72% 76.58% -0.15%
==========================================
Files 997 997
Lines 53238 53238
Branches 6772 6772
==========================================
- Hits 40847 40770 -77
- Misses 12161 12238 +77
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -34,7 +34,7 @@ REGEXES=() | |||
| for CHECK in "$@" | |||
| do | |||
| if [[ ${CHECK} == "python" ]]; then | |||
| REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt)" | |||
| REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt|^\.pylintrc)" | |||
There was a problem hiding this comment.
I agree with this; these are so uncommon doing a bit of overkill here is better than not doing it at all.
* master: chore(pylint): Reenable ungrouped-imports check (#16256) chore(pylint): Re-enable super-with-arguments check (#16138) fix: disable text reports for now (#16257) fix: pivot col names in post_process (#16262) chore: Improves the flow to create a new chart (#16252) Move pagination outside of table (#16232)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
SUMMARY
Re-enabling the Pylint
ungrouped-importscheck. This is a no-op since #16146 which bumped the version of Pylint to resolve a number of false positiveungrouped-importserrors related toTYPE_CHECKING. See pylint-dev/pylint#3382 for more details.TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION