Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CRUD view URLs more user-friendly #11622

Closed
ktmud opened this issue Nov 9, 2020 · 2 comments
Closed

Make CRUD view URLs more user-friendly #11622

ktmud opened this issue Nov 9, 2020 · 2 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@ktmud
Copy link
Member

ktmud commented Nov 9, 2020

Screenshot

Description

As a professional software, the URLs should be intuitive and predictable. Currently most CRUD view pages have automatically-generated URL pathnames which looks kind of hacky. We should change them to something more user-friendly, let them follow the Superset nomenclature instead the internal Python model/view names.

Datasets: /tablemodelview/ -> /datasets
Databases: /databaseview/ -> /databases

Design input

[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review. If this includes a design proposal,
include the label design:suggest]

@ktmud ktmud added the #bug:cosmetic Cosmetic/layout/design tweak needed label Nov 9, 2020
@issue-label-bot issue-label-bot bot added the enhancement:request Enhancement request submitted by anyone from the community label Nov 9, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@nytai
Copy link
Member

nytai commented Nov 9, 2020

This has been bothering me too. There's some legacy here, as you've pointed out regarding

internal Python model/view names

Listing out what would be required to make this happen:

  • Set up redirects for the old routes (in case users have bookmarked these urls)
  • set up backend routing for these new routes
  • set up react-router routes for the new routes
  • There's likely something else I'm missing.

We should wait until the react crud views are complete and we can fully deprecate the old FAB views since I don't think there's a way to change the routes for the old FAB views.

@junlincc junlincc removed the #bug:cosmetic Cosmetic/layout/design tweak needed label Nov 25, 2020
@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18416 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

No branches or pull requests

3 participants