Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-filters): Hide native filters from list of charts #14836

Closed
wants to merge 10 commits into from

Conversation

simcha90
Copy link
Contributor

SUMMARY

Fix: #14308

Hide native filters from list of charts

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@simcha90 simcha90 changed the title Hide native feat(native-filters): Hide native filters from list of charts May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #14836 (9eb8062) into master (bee6f3b) will increase coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14836      +/-   ##
==========================================
+ Coverage   77.41%   77.48%   +0.07%     
==========================================
  Files         962      962              
  Lines       49093    49166      +73     
  Branches     6165     6185      +20     
==========================================
+ Hits        38006    38098      +92     
+ Misses      10883    10866      -17     
+ Partials      204      202       -2     
Flag Coverage Δ
javascript 72.44% <50.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 73.57% <50.00%> (-0.53%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 64.86% <0.00%> (-13.71%) ⬇️
...tend/src/filters/components/Select/controlPanel.ts 58.33% <0.00%> (-5.31%) ⬇️
...ontend/src/explore/controlUtils/getControlState.ts 88.73% <0.00%> (-2.58%) ⬇️
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 26.31% <0.00%> (-1.47%) ⬇️
...nd/src/explore/components/ExploreViewContainer.jsx 2.15% <0.00%> (-0.15%) ⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx 67.44% <0.00%> (-0.13%) ⬇️
superset-frontend/src/explore/constants.ts 100.00% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 58.97% <0.00%> (ø)
...et-frontend/src/filters/components/Select/index.ts 100.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee6f3b...9eb8062. Read the comment docs.

@villebro
Copy link
Member

This was preceded by #14814 (slightly broader scope and introduces tests).

@villebro villebro closed this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter type are listed as viz type
2 participants