New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native-filters): introduce experimental feature flag #14814
chore(native-filters): introduce experimental feature flag #14814
Conversation
f91f5e1
to
6d96d43
Compare
Codecov Report
@@ Coverage Diff @@
## master #14814 +/- ##
==========================================
- Coverage 77.52% 77.51% -0.02%
==========================================
Files 962 962
Lines 49168 49175 +7
Branches 6184 6190 +6
==========================================
Hits 38119 38119
- Misses 10847 10853 +6
- Partials 202 203 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6d96d43
to
4f9cd11
Compare
Codecov Report
@@ Coverage Diff @@
## master #14814 +/- ##
==========================================
+ Coverage 77.60% 77.61% +0.01%
==========================================
Files 962 963 +1
Lines 49192 49245 +53
Branches 6184 6197 +13
==========================================
+ Hits 38176 38223 +47
- Misses 10814 10821 +7
+ Partials 202 201 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Product signed-off
Screen.Recording.2021-05-25.at.10.10.49.AM.mov
4f9cd11
to
ce5e25c
Compare
ce5e25c
to
7267523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
Introduce new feature flag to hide experimental native/cross filter functionality. Makes the following changes:
FEATURE FLAG DISABLED
Filter config modal filter type dropdown:
Viz type gallery:
Filter type dropdown on charts page:
FEATURE FLAG ENABLED
Filter config modal filter type dropdown:
Viz gallery:
Filter type dropdown on charts page (Groupby filter is being picked up due to the description being "Time grain filter plugin" i.e. includes the character sequence "fil"):
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION