Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(native-filters): introduce experimental feature flag #14814

Merged
merged 3 commits into from May 26, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented May 25, 2021

SUMMARY

Introduce new feature flag to hide experimental native/cross filter functionality. Makes the following changes:

  • move Groupby Plugin behind FF
  • Only show native filters in viz gallery and chart viz type dropdown if FF is enabled.

FEATURE FLAG DISABLED

Filter config modal filter type dropdown:
image

Viz type gallery:
image

Filter type dropdown on charts page:
image

FEATURE FLAG ENABLED

Filter config modal filter type dropdown:
image

Viz gallery:
image

Filter type dropdown on charts page (Groupby filter is being picked up due to the description being "Time grain filter plugin" i.e. includes the character sequence "fil"):
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: closes filter type are listed as viz type #14308
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro force-pushed the villebro/filter-experimental branch from f91f5e1 to 6d96d43 Compare May 25, 2021 14:32
@villebro villebro changed the title [WIP] chore(native-filters): introduce experimental feature flag chore(native-filters): introduce experimental feature flag May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #14814 (6d96d43) into master (63dc035) will decrease coverage by 0.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14814      +/-   ##
==========================================
- Coverage   77.52%   77.51%   -0.02%     
==========================================
  Files         962      962              
  Lines       49168    49175       +7     
  Branches     6184     6190       +6     
==========================================
  Hits        38119    38119              
- Misses      10847    10853       +6     
- Partials      202      203       +1     
Flag Coverage Δ
javascript 72.38% <11.11%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/explore/components/controls/VizTypeControl.jsx 80.00% <0.00%> (-1.49%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 72.53% <25.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63dc035...6d96d43. Read the comment docs.

@villebro villebro force-pushed the villebro/filter-experimental branch from 6d96d43 to 4f9cd11 Compare May 25, 2021 16:40
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #14814 (77e53d5) into master (4502086) will increase coverage by 0.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14814      +/-   ##
==========================================
+ Coverage   77.60%   77.61%   +0.01%     
==========================================
  Files         962      963       +1     
  Lines       49192    49245      +53     
  Branches     6184     6197      +13     
==========================================
+ Hits        38176    38223      +47     
- Misses      10814    10821       +7     
+ Partials      202      201       -1     
Flag Coverage Δ
javascript 72.48% <69.23%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plore/components/controls/VizTypeControl/index.jsx 92.59% <ø> (+2.93%) ⬆️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 73.75% <66.66%> (-0.35%) ⬇️
...nd/src/dashboard/components/nativeFilters/utils.ts 81.63% <100.00%> (+1.14%) ⬆️
...c/filters/components/Select/SelectFilterPlugin.tsx 64.86% <0.00%> (ø)
...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx 84.21% <0.00%> (ø)
...tersConfigModal/FiltersConfigForm/ControlItems.tsx
...nfigModal/FiltersConfigForm/CollapsibleControl.tsx 72.22% <0.00%> (ø)
...nfigModal/FiltersConfigForm/getControlItemsMap.tsx 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4502086...77e53d5. Read the comment docs.

@junlincc junlincc self-requested a review May 25, 2021 17:11
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Product signed-off

Screen.Recording.2021-05-25.at.10.10.49.AM.mov

@villebro villebro requested a review from zhaoyongjie May 25, 2021 17:49
@junlincc junlincc added bash! dashboard:native-filters Related to the native filters of the Dashboard labels May 25, 2021
@villebro villebro force-pushed the villebro/filter-experimental branch from 4f9cd11 to ce5e25c Compare May 26, 2021 07:15
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 26, 2021
@villebro villebro force-pushed the villebro/filter-experimental branch from ce5e25c to 7267523 Compare May 26, 2021 07:18
@villebro villebro added assigned:preset Assigned to the Preset team and removed assigned:preset Assigned to the Preset team labels May 26, 2021
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit e466066 into apache:master May 26, 2021
@junlincc junlincc added this to In progress in Native dashboard filters via automation May 27, 2021
@junlincc junlincc moved this from In progress to Done in Native dashboard filters May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
)

* chore(native-filters): introduce experimental feature flag

* break out util and add tests

* fix import
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
)

* chore(native-filters): introduce experimental feature flag

* break out util and add tests

* fix import
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
)

* chore(native-filters): introduce experimental feature flag

* break out util and add tests

* fix import
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard preset-io size/L 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

filter type are listed as viz type
5 participants