Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The docker image tagged latest does not deploy the latest stable version #16679

Closed
qiaofeng1227 opened this issue Sep 13, 2021 · 14 comments
Closed
Assignees
Labels
validation:validated A committer has validated / submitted the issue or it was reported by multiple users

Comments

@qiaofeng1227
Copy link

qiaofeng1227 commented Sep 13, 2021

image

image

image

@qiaofeng1227 qiaofeng1227 added the #bug Bug report label Sep 13, 2021
@qiaofeng1227
Copy link
Author

I want to use docker-compose.yml to get a product version of superset, but the version is 0.0.0dev.
There is something wrong with my operation. Please help me. Thank you very much.

@qiaofeng1227
Copy link
Author

I start superset follow the documentation:
https://superset.apache.org/docs/installation/installing-superset-using-docker-compose

@qqliang
Copy link

qqliang commented Sep 14, 2021

I ran into the same problem. I wanna know the version of superset in docker, which is convenient for development.

@youngsol
Copy link

youngsol commented Oct 4, 2021

image
change this line to

apache/superset:1.3.0

@junlincc junlincc added need:community-volunteer Requires a community volunteer and removed #bug Bug report labels Oct 22, 2021
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas
Copy link
Member

rusackas commented Feb 2, 2023

This is an old/stale issue, but I fear it may still be relevant. Any input @hughhhh / @craig-rueda ?

@stale stale bot removed the inactive Inactive for >= 30 days label Feb 2, 2023
@Robin-Brandt
Copy link

I can confirm this issue still persists in the frontend on version 1.5.3

@sfirke
Copy link
Member

sfirke commented Mar 1, 2023

What is the issue - that running a latest dev version shows 0.0.0dev in the UI? That doesn't feel like a bug necessarily but some of the friction here could be addressed by implementing a new tag like official and pointing people to that instead of latest, as discussed here: #22244

@JoeJordan1
Copy link

I can also confirm that this is still an issue. We also pull the latest version in docker, however the UI only shows 0.0.0dev. When looking in the running app, as explained here: #4634 I have checked both the package.json file and version_info.json but they also just list the version as 0.0.0dev.

I have recently upgraded superset to the latest 3.0.1 release, I believe, but I can't confirm whether the upgrade has worked, as I can't determine the version either prior to or after the upgrade. I think the only way to check is to trawl through the UI for features that may have been introduced, but this is by no means a reliable solution.

@sfirke
Copy link
Member

sfirke commented Nov 20, 2023

The Superset build process was recently changed so that the latest docker tag should point to the latest official release. Right now that's 3.0.1. See Pull Request #25322. Unfortunately things still seem to need work here. I'm renaming the issue title to reflect the current problem, post-PR #25322.

I am comparing the contents of the latest image with the contents of the 3.0.1 image. They are not identical. The latest image was created 7 hours later on the same day (2023-10-18), it's bigger (1.29GB instead of 1.11GB), and most troubling when I switch from 3.0.1 to latest on the same metadata db the installation breaks due to an apparent database migration.

What Superset administrators can do: don't point to the latest image in your Docker or Kubernetes deployment, instead point to a specific release tag like 3.0.1.

What developers & the project can do: Have the latest tag be applied to the image so that 3.0.1 and latest are identical. Ideally latest is just functioning like an alias. This would mean that users see 3.0.1 as the version inside the UI.

@sfirke sfirke changed the title I want to latest release version by docker install ,but settings menu show version is 0.0.0.dev The docker image tagged latest does not deploy the latest stable version Nov 20, 2023
@sfirke sfirke added validation:validated A committer has validated / submitted the issue or it was reported by multiple users and removed need:community-volunteer Requires a community volunteer labels Nov 20, 2023
@rusackas
Copy link
Member

rusackas commented Feb 1, 2024

Tagging @mistercrunch to look into the relevance of this now that things have been tweaked significantly.

@mistercrunch
Copy link
Member

mistercrunch commented Feb 1, 2024

I need docker hub push perms to re-publish or tag older releases! Currently it's only triggered by CI where the perms exist, and it's tricky to do since the GitHub action and docker logic is different in the old branches.

Question though, are we mostly caring about overall latest builds here?

Wondering if there's such thing as "major" and "micro" latest tags as in 3.0-latest (might point to 3.0.99), and 3-latest might point to 3.99.99

@mistercrunch
Copy link
Member

Note that I documented the work that I did here https://github.com/apache/superset/pull/26923/files#diff-3d81145232d337c575e1626a0d209c2e9219a42ade8fd214499acc13d8dbe185 , but it only affects builds moving forward for now.

@rusackas
Copy link
Member

Sounds like things are all fixed going forward, so we can likely close this out as an active issue. If anyone disagrees, we can certainly revisit/reopen as warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation:validated A committer has validated / submitted the issue or it was reported by multiple users
Projects
None yet
Development

No branches or pull requests