Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking 'Applied filters' tooltip causes unexpected tab switch #26262

Closed
2 of 3 tasks
eram opened this issue Dec 13, 2023 · 4 comments
Closed
2 of 3 tasks

Clicking 'Applied filters' tooltip causes unexpected tab switch #26262

eram opened this issue Dec 13, 2023 · 4 comments
Assignees

Comments

@eram
Copy link

eram commented Dec 13, 2023

A clear and concise description of what the bug is.

How to reproduce the bug

  1. On a dashboard with multiple tabs, click open non-default tab
  2. Set some filter
  3. Click the "Applied filters" icon on the top right of a chart. This would open the tootip.
  4. Click anywhere in the tooltip

Expected results

Nothing other than text selection.

Actual results

The display switches to show a different tab.

Screenshots

I have attached screenshotsand video.
Screenshot 2023-11-27 at 14 43 12
video

Environment

(please complete the following information):

  • browser type and version: chrome, firefox
  • superset version: 3.0
  • python version: python --version
  • node.js version: node -v
  • any feature flags active: EMBEDDED, CROSS FILTERS

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

The attached screenshot and vid are from an embedded view, but the same issue is reproduced on the main superset dashboard.

@michael-s-molina
Copy link
Member

@sadpandajoe @jinghua-qa

@michael-s-molina
Copy link
Member

@kgabryje I think this PR is the source for the error.

@kgabryje
Copy link
Member

Thanks for digging @michael-s-molina ! I’ll check it out

@kgabryje
Copy link
Member

Thanks for reporting @eram, this PR should fix the issue #26340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants