Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Save Slice dialog #3960

Closed
mistercrunch opened this issue Nov 30, 2017 · 3 comments
Closed

Improve Save Slice dialog #3960

mistercrunch opened this issue Nov 30, 2017 · 3 comments
Labels
good first issue Good first issues for new contributors inactive Inactive for >= 30 days

Comments

@mistercrunch
Copy link
Member

mistercrunch commented Nov 30, 2017

screen shot 2017-11-29 at 10 17 41 pm

  • make dashboard dropdown sticky (use cookie?)
  • when overwriting a slice that is already associated to a dash, save & go should take you to the dash
@rumbin
Copy link
Contributor

rumbin commented Nov 30, 2017

Some thoughts on your second item:

If a slice is already associated to more than one dashboard, what is the user's expectation?

  • only take into account the dashboards that he owns?
  • ask which one to forward to?
  • take the most recently changed one?
  • or the one which the user last accessed, and which maybe led him to editing this slice?

@mistercrunch
Copy link
Member Author

I thought about this as I was writing the issue...

From my experience it's pretty rare that one slice is in two dashboards, but we should still handle it. I'd say prefer one that the user owns, otherwise pick one at random. Could also include the title in the button [Save & go to "My Dashboard"]

@stale
Copy link

stale bot commented Apr 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 11, 2019
@stale stale bot closed this as completed Apr 18, 2019
@mistercrunch mistercrunch added the good first issue Good first issues for new contributors label Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issues for new contributors inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

2 participants