Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treemap splits labels on . #9354

Closed
3 tasks done
serenajiang opened this issue Mar 23, 2020 · 3 comments
Closed
3 tasks done

Treemap splits labels on . #9354

serenajiang opened this issue Mar 23, 2020 · 3 comments
Labels
!deprecated-label:bug Deprecated label - Use #bug instead .pinned Draws attention viz:charts:treemap Related to the Treemap chart

Comments

@serenajiang
Copy link
Contributor

In the treemap viz, labels are split on ., and the last "word" is used for the viz.

Expected results

For the label google.com, the label should read google.com

Actual results

image 🤔

How to reproduce the bug

  1. SELECT 'google.com' AS col_a in sqllab
  2. Explore chart
  3. Create a treemap viz with metric COUNT, grouped by col_a
  4. Run Query

Environment

(please complete the following information):

  • superset version: superset version: Up to date with master as of 2020-03-18
  • python version: python --version: 3.6
  • node.js version: node -v
  • npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@stale
Copy link

stale bot commented May 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 22, 2020
@stale stale bot closed this as completed May 30, 2020
@mistercrunch mistercrunch added the .pinned Draws attention label May 31, 2020
@mistercrunch mistercrunch reopened this May 31, 2020
@stale stale bot removed the inactive Inactive for >= 30 days label May 31, 2020
@mistercrunch mistercrunch added starter-task !deprecated-label:bug Deprecated label - Use #bug instead labels May 31, 2020
@mistercrunch
Copy link
Member

For whoever wants to work on this, here's a pointer to the source:
https://github.com/apache-superset/superset-ui/blob/master/plugins/legacy-plugin-chart-treemap/src/Treemap.js#L135-L158

@mistercrunch mistercrunch added the good first issue Good first issues for new contributors label Sep 18, 2020
@junlincc junlincc added the chart label Nov 25, 2020
@junlincc junlincc added viz:charts:treemap Related to the Treemap chart and removed .vis good first issue Good first issues for new contributors labels Jan 2, 2021
@rusackas
Copy link
Member

Closing this issue as stale, since the Legacy Treemap is effectively being replaced by the Treemap (Echarts) plugin, which does not exhibit this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead .pinned Draws attention viz:charts:treemap Related to the Treemap chart
Projects
None yet
Development

No branches or pull requests

4 participants