feat(dashboard_rbac): add support for related roles #13035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitmiran137
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13035 +/- ##
==========================================
+ Coverage 53.06% 62.17% +9.11%
==========================================
Files 489 985 +496
Lines 17314 46340 +29026
Branches 4482 4510 +28
==========================================
+ Hits 9187 28811 +19624
- Misses 8127 17529 +9402
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
added
the
dashboard:security:access
villebro
reviewed
Feb 10, 2021
* fix: fix the untranslated text content of Dashboard page * fix: add the untranslated text content of Dashboard page in messages.pot * fix linting error Co-authored-by: chenx <yuxiang1989>
…3039) * fix(build): black failing on master * Add pre-commit to required checks
…pache#12602) * feat(db engines): add support for Opendistro Elasticsearch (AWS ES) * add time grains * lint * bump elasticsearch-dbapi version * add tests * fix test
* fix: UI toast typo * translate * fix error msg
* fix: timeout decorator in Windows * Fix lint
* Update README.md * Update introduction.mdx
* button fix * tooltips disabled when it is disabled, border width changed * added isDisabled to tooltip * worked on transition times * cleaned up transition to be local instead of global * made it local * linted * trying to resolve a conflict
* feat(native-filters): hide dashboard header bu url parameter * lint: fix lint * test: add tests * test: fix test * refactor: upgrade standalone param * fix: pre-commit and extract to method is_standalone_mode * test: fix tests * test: fix tests * fix: fix standalone statement * refactor: fix CR notes * chore: pre-commit * fix: fix sticky tabs + update CR notes * lint: fix lint * lint: fix lint * fix: fix CR notes * fix: fix CR notes * lint: fix lint * refactor: fix cr notes Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
* fix(ci): multiline regex in change detection * fix shellcheck issues
* fix: Retroactively add granularity param to charts * Update down revision
…3051) * fix: add config to disable dataset ownership on the old api * fix CI docker build * fix logic * add deprecation comment on the config
…#13076) * fix: API tests, possible to run independently * fix workflow name
- Adds plugin:jest-dom/recommended to ESLint plugins list to enforce tests best practices - Moves import @testing-library/jest-dom/extend-expect; from setup.ts to testing-library.tsx to avoid matchers collision - Adds @testing-library/user-event to help simulate users events
* feat: add cross filters * refactor: fix CR notes * lint: fix lint * lint: fix lint * chore: pre-commit * refactor: under chage * refactor: move to behaviors * lint: fix lint Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
* Add Time Filter component * Improve Time Filter component * Fix import errors * Display Time Filter * Remove console logs * Change Control Panel * Remove unnecessary files * Use time range override * test: fix tests * feat: re run pipeline * fix: fix some case for Time filter * fix: merge with master * use original time range * fix height * add cross filter behavior * apply filters on initialization * add applied filter to overrides * add unit tests for merge_extra_form_data Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
…3005) * refactor: update native filters ignores * refactor: use behaviour variable * refactor: move story for Filter select * chore: update dependencies * lint: fix lint * remove unnecessary changes Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
…irst phase) (apache#13021) * refactor: decouple params from filter config modal (first phase) * refactor: remove unnecessary fields * refactor: fix CR notes * fix: fix controlValues * refactor: fix Cr notes Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
* master: (30 commits) refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021) fix(native-filters): set currentValue null when empty (apache#13000) Custom superset_config.py + secret envs (apache#13096) Update http error code from 400 to 403 (apache#13061) feat(native-filters): add storybook entry for select filter (apache#13005) feat(native-filters): Time native filter (apache#12992) Force pod restart on config changes (apache#13056) feat(cross-filters): add cross filters (apache#12662) fix(explore): Enable selecting an option not included in suggestions (apache#13029) Improves RTL configuration (apache#13079) Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083) chore: lock down npm to v6 (apache#13069) fix: API tests, make them possible to run independently again (apache#13076) fix: add config to disable dataset ownership on the old api (apache#13051) add required * indicator to message content/notif method (apache#12931) fix: Retroactively add granularity param to charts (apache#12960) fix(ci): multiline regex in change detection (apache#13075) feat(style): hide dashboard header by url parameter (apache#12918) fix(explore): pie chart label bugs (apache#13052) fix: Disabled state button transition time (apache#13008) ...
dpgaspar
approved these changes
Feb 15, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
an alternateive for #12993
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION