Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: "revert fix(dashboard): multiple query trigger when native filter enabled" #14762

Merged
merged 1 commit into from May 22, 2021

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

This reverts commit 88de410.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #14762 (8b52033) into master (c7aee4e) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14762      +/-   ##
==========================================
- Coverage   77.63%   77.63%   -0.01%     
==========================================
  Files         962      962              
  Lines       49015    49017       +2     
  Branches     6153     6155       +2     
==========================================
+ Hits        38051    38052       +1     
- Misses      10760    10761       +1     
  Partials      204      204              
Flag Coverage Δ
hive 81.37% <ø> (ø)
javascript 72.41% <66.66%> (-0.02%) ⬇️
mysql 81.65% <ø> (ø)
postgres 81.67% <ø> (ø)
presto 81.37% <ø> (+<0.01%) ⬆️
python 82.20% <ø> (+<0.01%) ⬆️
sqlite 81.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hboard/components/nativeFilters/FilterBar/state.ts 88.63% <66.66%> (-4.23%) ⬇️
.../FilterBar/CascadeFilters/CascadePopover/index.tsx 63.38% <0.00%> (-1.41%) ⬇️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7aee4e...8b52033. Read the comment docs.

@zhaoyongjie zhaoyongjie changed the title Revert "fix(dashboard): multiple query trigger when native filter ena… other: "fix(dashboard): multiple query trigger when native filter ena… May 22, 2021
@zhaoyongjie zhaoyongjie changed the title other: "fix(dashboard): multiple query trigger when native filter ena… other: "revert fix(dashboard): multiple query trigger when native filter enabled" May 22, 2021
@zhaoyongjie zhaoyongjie merged commit d71b8b3 into apache:master May 22, 2021
amitmiran137 added a commit to nielsen-oss/superset that referenced this pull request May 25, 2021
* master: (163 commits)
  fix(native-filters): Manage default value of filters by superset (apache#14785)
  fix: Additional ResultSet tests (apache#14741)
  chore: added BasicParametersMixin to Redshift (apache#14752)
  fix: make dataset list sort case insensitive (apache#14528)
  fix: use encodeURIComponent when getting table metadata (apache#14790)
  fix: ensure engine is outside parameters (apache#14787)
  database modal should close on connect with tab layout (apache#14771)
  feat(native-filters): add search all filter options (apache#14710)
  fix: extra query in Dashboard when native filter enabled (apache#14770)
  chore: Improves the native filters UI/UX - iteration 2 (apache#14753)
  fix(native filters): Fix explore state (apache#14779)
  fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737)
  feat: Create BigQuery Parameters for DatabaseModal (apache#14721)
  feat: enable user impersonation in GSheets (apache#14767)
  fix: add DB should not say it's Postgres (apache#14766)
  Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762)
  feat: save database with new dynamic form (apache#14583)
  fix: save non-parameter DBs (apache#14759)
  chore: Removes ColorSchemeControl.less (apache#14199)
  fix(explore): Icons width (apache#14717)
  ...
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants