fix: ensure engine is outside parameters #14787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
move_engine_outside_params
branch
from
5016072
to
1fe023b
Compare
betodealmeida
commented
May 24, 2021
Comment on lines
+273
to
+277
| serialized_encrypted_extra = data.get("encrypted_extra", "{}") | ||
| try: | ||
| encrypted_extra = json.loads(serialized_encrypted_extra) | ||
| except json.decoder.JSONDecodeError: | ||
| encrypted_extra = {} |
There was a problem hiding this comment.
I moved this closer to where is needed, to prevent us from running this if not necessary.
betodealmeida
force-pushed
the
move_engine_outside_params
branch
from
1fe023b
to
8574282
Compare
Codecov Report
@@ Coverage Diff @@
## master #14787 +/- ##
==========================================
- Coverage 77.54% 77.30% -0.25%
==========================================
Files 962 962
Lines 49147 49148 +1
Branches 6182 6182
==========================================
- Hits 38111 37993 -118
- Misses 10832 10951 +119
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
approved these changes
May 24, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
May 25, 2021
* master: (163 commits) fix(native-filters): Manage default value of filters by superset (apache#14785) fix: Additional ResultSet tests (apache#14741) chore: added BasicParametersMixin to Redshift (apache#14752) fix: make dataset list sort case insensitive (apache#14528) fix: use encodeURIComponent when getting table metadata (apache#14790) fix: ensure engine is outside parameters (apache#14787) database modal should close on connect with tab layout (apache#14771) feat(native-filters): add search all filter options (apache#14710) fix: extra query in Dashboard when native filter enabled (apache#14770) chore: Improves the native filters UI/UX - iteration 2 (apache#14753) fix(native filters): Fix explore state (apache#14779) fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737) feat: Create BigQuery Parameters for DatabaseModal (apache#14721) feat: enable user impersonation in GSheets (apache#14767) fix: add DB should not say it's Postgres (apache#14766) Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762) feat: save database with new dynamic form (apache#14583) fix: save non-parameter DBs (apache#14759) chore: Removes ColorSchemeControl.less (apache#14199) fix(explore): Icons width (apache#14717) ...
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the new database modal flow we have 2 different flows:
test_connection, add/edit DB) we expectengineinsideparameters.validate_parameters) it should be outside.It's better to have a consistent way, and it's also better to have engine outside of parameters, so I fixed the old APIs to support both initially, to prevent breaking the frontend. Later we can remove support for passing
engineinsideparametersand only accept it outside.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Tested manually.
ADDITIONAL INFORMATION