fix(native-filters): avoid double load on select initialization #15012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
changed the title
simcha90
reviewed
Jun 7, 2021
| @@ -109,6 +109,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { | |||
| } = formData; | |||
| const groupby = ensureIsArray<string>(formData.groupby); | |||
| const [col] = groupby; | |||
| const [initialColtypeMap] = useState(coltypeMap); | |||
There was a problem hiding this comment.
I'm not sure if this proposal will be rellevant, but may be it can make sense instead of split state to different places we can control calls of setDataMask hook, for example - not call it if doesn't have filled own state or stuff like that, because if we will have some more logic for own state we can get same issue, or may be I wrong
There was a problem hiding this comment.
I think we should ultimately make the chart component check if a call to buildQuery actually returns a changed query. This way we could avoid retriggering queries when ownState changes but the actual QueryObjects or QueryContext doesn't change.
simcha90
approved these changes
Jun 7, 2021
junlincc
added
the
dashboard:native-filters
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jun 8, 2021
* upstream/master: fix(explore): Datepicker glitch on hover outside the modal (apache#15033) Add ming-height to empty tab (apache#14878) Remove nowrap (apache#14954) display all metric results in editor (apache#15031) feat: Add "is_select_query" method to base engine spec to make it possible to override it (apache#15013) fix(dashboard): custom css should be removed on unmount (apache#15025) feat(filter-box): hide druid options if druid not enabled (apache#14921) fix: adding additional configs and colors for queryHistory (apache#14995) chore: rename 'Source' to 'Database' for consistency (apache#15021) chore(ci): fix ci conflict (apache#15016) fix(native-filters): avoid double load on initialization (apache#15012) feat(native-filters): Support default to first value in select filter (apache#14869) docs: required information for OAuth2 configuration (apache#15010) Update index.mdx (apache#14990)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently select filters make two requests for data upon initialization. This is due to the filter adding column type mappings to
ownStateon initialization. Since these are only needed when "Search all options" is enabled, the initial column type mappings are stored on initialization, and are added toownStateonly when needed.BEFORE
Currently the "Continent" filter generates two requests (the last two requests to "data"); the first with
ownState: {}and the second withownState: { colTypeMap: region: 1 }. Note that the request is the same, due toownStatenot changing the generated query inbuildQuery:AFTER
Now loading the Filter Tab only causes one single request on initialization, both when "Search all options" is enabled and disabled (
ownStateis added todataMaskwhen the first update happens):BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Updated tests + added new test to ensure that
ownStateis populated correctly whensearchAllOptionsistrue.ADDITIONAL INFORMATION