feat(filter-box): hide druid options if druid not enabled #14921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14921 +/- ##
==========================================
+ Coverage 77.43% 77.52% +0.08%
==========================================
Files 966 963 -3
Lines 49590 49331 -259
Branches 6293 6240 -53
==========================================
- Hits 38402 38243 -159
+ Misses 10986 10889 -97
+ Partials 202 199 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/filterbox-controls
branch
from
fccaa38
to
8e0e088
Compare
kgabryje
reviewed
May 31, 2021
| @@ -20,6 +20,37 @@ import React from 'react'; | |||
| import { t } from '@superset-ui/core'; | |||
| import { sections } from '@superset-ui/chart-controls'; | |||
|
|
|||
| const appContainer = document.getElementById('app'); | |||
| const bootstrapData = JSON.parse(appContainer.getAttribute('data-bootstrap')); | |||
There was a problem hiding this comment.
I think that we usually parse bootstrapped data in the main index file of a given view. Do you think we could move those 2 lines higher in the files hierarchy as well?
There was a problem hiding this comment.
I found this code in src/explore/index.jsx but I don't know if we are storingbootstrapData.common.conf somewhere...
const exploreViewContainer = document.getElementById('app');
const bootstrapData = JSON.parse(
exploreViewContainer.getAttribute('data-bootstrap'),
);
initFeatureFlags(bootstrapData.common.feature_flags);
junlincc
added
rush!
nytai
approved these changes
Jun 2, 2021
|
🏷️ 2021.21 |
rusackas
approved these changes
Jun 7, 2021
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 8, 2021
* feat(filter-box): hide druid options if druid not enabled * add bootstrap export (cherry picked from commit 422c32c)
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jun 8, 2021
* upstream/master: fix(explore): Datepicker glitch on hover outside the modal (apache#15033) Add ming-height to empty tab (apache#14878) Remove nowrap (apache#14954) display all metric results in editor (apache#15031) feat: Add "is_select_query" method to base engine spec to make it possible to override it (apache#15013) fix(dashboard): custom css should be removed on unmount (apache#15025) feat(filter-box): hide druid options if druid not enabled (apache#14921) fix: adding additional configs and colors for queryHistory (apache#14995) chore: rename 'Source' to 'Database' for consistency (apache#15021) chore(ci): fix ci conflict (apache#15016) fix(native-filters): avoid double load on initialization (apache#15012) feat(native-filters): Support default to first value in select filter (apache#14869) docs: required information for OAuth2 configuration (apache#15010) Update index.mdx (apache#14990)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* feat(filter-box): hide druid options if druid not enabled * add bootstrap export
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* feat(filter-box): hide druid options if druid not enabled * add bootstrap export
geido
added
explore:control
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* feat(filter-box): hide druid options if druid not enabled * add bootstrap export
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the filter box control panel shows legacy Druid specific controls even when legacy Druid isn't enabled. This PR removes the Druid specific sections if legacy Druid is not enabled, and also moves the controls to their own rows. In addition, a new property is added to
bootstrapDatato list installed optional Python dependencies to be able to customize control panels that depend on this functionality (in this case this will be used to show/hide the forecast section in the ECharts timeseries plugin).BEFORE
Currently the SQL and Druid sections labels overlap each other:
AFTER
With
DRUID_IS_ACTIVEset to true:With
DRUID_IS_ACTIVEset to false:TESTING INSTRUCTIONS
ADDITIONAL INFORMATION