refactor: Add "is_select_query" method to base engine spec to unlock non-SQL dialects #15013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible to override it
betodealmeida
approved these changes
Jun 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #15013 +/- ##
==========================================
- Coverage 77.62% 77.39% -0.24%
==========================================
Files 965 965
Lines 49521 49524 +3
Branches 6263 6263
==========================================
- Hits 38442 38328 -114
- Misses 10878 10995 +117
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks for working on this, @Ceridan! |
amitmiran137
added a commit
to nielsen-oss/superset
that referenced
this pull request
Jun 8, 2021
* upstream/master: fix(explore): Datepicker glitch on hover outside the modal (apache#15033) Add ming-height to empty tab (apache#14878) Remove nowrap (apache#14954) display all metric results in editor (apache#15031) feat: Add "is_select_query" method to base engine spec to make it possible to override it (apache#15013) fix(dashboard): custom css should be removed on unmount (apache#15025) feat(filter-box): hide druid options if druid not enabled (apache#14921) fix: adding additional configs and colors for queryHistory (apache#14995) chore: rename 'Source' to 'Database' for consistency (apache#15021) chore(ci): fix ci conflict (apache#15016) fix(native-filters): avoid double load on initialization (apache#15012) feat(native-filters): Support default to first value in select filter (apache#14869) docs: required information for OAuth2 configuration (apache#15010) Update index.mdx (apache#14990)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…sible to override it (apache#15013)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…sible to override it (apache#15013)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…sible to override it (apache#15013)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We add
is_select_querymethod to thesuperset/db_engine_specs/base.pyto allow override it in the inherited specs.Reason:
We are working on the SQLAlchemy Kusto dialect (Azure Data Explorer) and want to propose the support of this dialect in Superset. The current problem is that KQL (Kusto Query Language) doesn't use "SELECT" keyword for queries, it is started from the table name instead. If we want to allow SQLLabs limits UI component to working properly, we need to have the ability to define which query is essentially the SELECT-query in our db engine spec file.
More details in the issue: #15011
TESTING INSTRUCTIONS
The functionality is still the same. Actually, you may just run any query in the SQLLab and verify that the limit (UI component) is still applying.
ADDITIONAL INFORMATION