Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter overlay in dashboard when scrolling #15140

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #14828

@rusackas @junlincc We need to allocate time in the future to manage the z-index globally. The lack of a global index is creating these bugs because each developer assigns an isolated z-index value and it's difficult to track conflicts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

119573651-6c3bb480-bd69-11eb-9268-536440f0ea17.mov
screen-recording-2021-06-13-at-122740-pm_2RyOMuas.mov

TESTING INSTRUCTIONS

See before/after videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #15140 (86d836e) into master (856a2bd) will not change coverage.
The diff coverage is n/a.

❗ Current head 86d836e differs from pull request most recent head c1b8344. Consider uploading reports for the commit c1b8344 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15140   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         969      969           
  Lines       49902    49902           
  Branches     6383     6383           
=======================================
  Hits        38671    38671           
  Misses      11029    11029           
  Partials      202      202           
Flag Coverage Δ
javascript 72.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Menu/Menu.tsx 67.05% <ø> (ø)
...d/components/DashboardBuilder/DashboardBuilder.tsx 91.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856a2bd...c1b8344. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit 82ad053 into apache:master Jun 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native-filter]Filter indicator overlay in Dashboard on scroll
3 participants