fix(dashboard): Add z-index to dashboard only when maximizing chart #15800

geido · 2021-07-20T14:23:44Z

SUMMARY

It adds the z-index to the dashboard only when maximizing charts in order to avoid display issues of overlapping items.

Fixes #15689

BEFORE

AFTER

untitled.dashb.2.mp4

TESTING INSTRUCTIONS

Open a dashboard in edit mode
Add a header component at the top and click on it
Make sure the options are appearing properly
Add a chart, save the dashboard and maximize the chart
Make sure the chart is taking all the available space

ADDITIONAL INFORMATION

Has associated issue: [cosmetic][dashboard edit] style bar of the dashboard component in the first line is half covered #15689
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

geido · 2021-07-20T14:26:13Z

@jinghua-qa @rosemarie-chiu

geido · 2021-07-20T14:43:09Z

/testenv up

codecov · 2021-07-20T14:43:21Z

Codecov Report

Merging #15800 (a6b89c2) into master (2aa8899) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #15800   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files         983      983           
  Lines       51635    51635           
  Branches     6994     6994           
=======================================
  Hits        39800    39800           
  Misses      11609    11609           
  Partials      226      226

Flag	Coverage Δ
javascript	`71.70% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx	`90.38% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa8899...a6b89c2. Read the comment docs.

github-actions · 2021-07-20T14:46:23Z

@geido Ephemeral environment spinning up at http://34.220.198.48:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas

LGTM!

github-actions · 2021-07-20T17:09:12Z

Ephemeral environment shutdown and build artifacts deleted.

#15856) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat: toggle the ReportModal Icon based on user permissions (#15780) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * added testing props * cleaned up rebase * changed name and type Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * feat: Begin incorporation of email report modal to Charts (#15793) * Add email report modal to Charts * Fix px themes * feat: fetch UI specific reports (#15785) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * created Api call * added click logic * made the fetch report into a action/reducer * abstracted report action * revision * added reportState to reducer * reports conditions * revisions * revisions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * fix: Edit physical dataset from the Edit Dataset modal (#15770) * Remove unnecessary onChange * Remove confliciting onChange * Revert unnecessary change * Enhance and fix tests * feat: add show columns to Reports model (#15712) * added logic for creation_method * revisions * added index * Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py * filters * search columns updated * fix: margin right on warning icon to 8px (#15715) * changed margin right on warning icon to 8px * fixed to grid units from pixels * feat: adding Progress Bar to Benchmark script (#15719) * rough draft of benchmark script * revisions * revisions * rough draft of benchmark script * revisions * Update requirements/development.in Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset/utils/mock_data.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * more revisions Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * fix: migration downgrade references wrong column (#15791) * fix(dashboard): Add resize handles to right and bottom of component (#15778) * fix(dashboard): Add resize handles to right and bottom of component * Fix test * chore: Add tags to the new viz gallery (#15734) * chore: add tags to gallery * fix UT * fix lint * redesign tags filter * chore: change to Highly-used and fix some css * fix UT Co-authored-by: stephenLYZ <750188453@qq.com> * chore: bump 0.17.70 (#15795) * docs: Adding Sunbird to users list (#15794) * chore: Improves the Select component UI/UX - iteration 4 (#15480) * Add z-index only on maximize (#15800) * chore: remove `retry` dependency in favor of `backoff` (#15788) * chore: remove retry dep in favor of backoff * Fix lint * fix: create fk model in benchmark script (#15804) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * Working on onSave functionality * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat: toggle the ReportModal Icon based on user permissions (#15780) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * added testing props * cleaned up rebase * changed name and type Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * feat: fetch UI specific reports (#15785) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * created Api call * added click logic * made the fetch report into a action/reducer * abstracted report action * revision * added reportState to reducer * reports conditions * revisions * revisions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * Dashboard onSave progress * More onSave/create progress * Dashboard POST working! * Dashboard POST relocated to redux * POST now also working in Charts * making linter happy * linter again Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: stellalc7 <stellalc7@gmail.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: stephenLYZ <750188453@qq.com> Co-authored-by: Kumar <kumarks1122@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Add z-index only on maximize

a6b89c2

superset-github-bot bot added the Flexiana label Jul 20, 2021

geido added this to In Review in Community Usability Bash! 🐛🐞🕷 Jul 20, 2021

geido requested review from junlincc, pkdotson and rusackas July 20, 2021 14:24

rusackas approved these changes Jul 20, 2021

View reviewed changes

rusackas merged commit cbd3780 into apache:master Jul 20, 2021

geido moved this from In Review to Done in Community Usability Bash! 🐛🐞🕷 Jul 21, 2021

amitmiran137 added the v1.3 label Jul 24, 2021

lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Jul 26, 2021

Add z-index only on maximize (apache#15800)

797efdd

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021

Add z-index only on maximize (apache#15800)

dcb8560

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021

Add z-index only on maximize (apache#15800)

41469c9

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

Add z-index only on maximize (apache#15800)

16bc054

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dashboard): Add z-index to dashboard only when maximizing chart #15800

fix(dashboard): Add z-index to dashboard only when maximizing chart #15800

geido commented Jul 20, 2021

geido commented Jul 20, 2021

geido commented Jul 20, 2021

codecov bot commented Jul 20, 2021

github-actions bot commented Jul 20, 2021

rusackas left a comment

github-actions bot commented Jul 20, 2021

fix(dashboard): Add z-index to dashboard only when maximizing chart #15800

fix(dashboard): Add z-index to dashboard only when maximizing chart #15800

Conversation

geido commented Jul 20, 2021

SUMMARY

BEFORE

AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

geido commented Jul 20, 2021

geido commented Jul 20, 2021

codecov bot commented Jul 20, 2021

Codecov Report

github-actions bot commented Jul 20, 2021

rusackas left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2021