feat: Create/onsave Email Report functionality for Dashboard and Chart #15856

lyndsiWilliams · 2021-07-23T06:01:39Z

SUMMARY

Implemented the Create/onsave Email Report functionality for Dashboard and Chart.

Bonus: Modal styling now matches more closely to Figma.

SCREENSHOT

TESTING INSTRUCTIONS

Click "Dashboards" in the upper navigation bar
Navigate to any Dashboard
Click the Calendar icon button
- Located at the top of the chart between the "Edit dashboard" and the "..." button
Observe the email report modal

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

* clears errors when closing out of modal (apache#15623) * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

…5780) * style: Rough draft of email report modal (apache#15666) * clears errors when closing out of modal (apache#15623) * fix: avoid fetching favorite status for anonymous user (apache#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * added testing props * cleaned up rebase * changed name and type Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt>

* Add email report modal to Charts * Fix px themes

* style: Rough draft of email report modal (apache#15666) * clears errors when closing out of modal (apache#15623) * fix: avoid fetching favorite status for anonymous user (apache#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * created Api call * added click logic * made the fetch report into a action/reducer * abstracted report action * revision * added reportState to reducer * reports conditions * revisions * revisions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt>

github-actions · 2021-07-26T17:21:31Z

⚠️ @lyndsiWilliams Your base branch selfSubscribeReports has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

* Remove unnecessary onChange * Remove confliciting onChange * Revert unnecessary change * Enhance and fix tests

* added logic for creation_method * revisions * added index * Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py * filters * search columns updated

* changed margin right on warning icon to 8px * fixed to grid units from pixels

* rough draft of benchmark script * revisions * revisions * rough draft of benchmark script * revisions * Update requirements/development.in Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset/utils/mock_data.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * more revisions Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

…pache#15778) * fix(dashboard): Add resize handles to right and bottom of component * Fix test

* chore: add tags to gallery * fix UT * fix lint * redesign tags filter * chore: change to Highly-used and fix some css * fix UT Co-authored-by: stephenLYZ <750188453@qq.com>

* chore: remove retry dep in favor of backoff * Fix lint

* clears errors when closing out of modal (apache#15623) * fix: avoid fetching favorite status for anonymous user (apache#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt>

* clears errors when closing out of modal (apache#15623) * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

…5780) * style: Rough draft of email report modal (apache#15666) * clears errors when closing out of modal (apache#15623) * fix: avoid fetching favorite status for anonymous user (apache#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * added testing props * cleaned up rebase * changed name and type Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt>

* style: Rough draft of email report modal (apache#15666) * clears errors when closing out of modal (apache#15623) * fix: avoid fetching favorite status for anonymous user (apache#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * created Api call * added click logic * made the fetch report into a action/reducer * abstracted report action * revision * added reportState to reducer * reports conditions * revisions * revisions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt>

github-actions · 2021-07-26T17:53:37Z

⚠️ @lyndsiWilliams Your base branch selfSubscribeReports has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

github-actions · 2021-07-26T18:05:07Z

⚠️ @lyndsiWilliams Your base branch selfSubscribeReports has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

github-actions · 2021-07-26T18:08:58Z

⚠️ @lyndsiWilliams Your base branch selfSubscribeReports has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

eschutho · 2021-07-26T20:56:30Z

superset-frontend/src/components/ReportModal/index.tsx

+    };
+
+    setLoading(true);
+    const currentReportID = await createResource(newReport as ReportObject);


instead of returning the id here, let it fall into state..

eschutho · 2021-07-26T20:56:42Z

superset-frontend/src/components/ReportModal/index.tsx

+    setLoading(true);
+    const currentReportID = await createResource(newReport as ReportObject);
+
+    if (currentReportID) {


this then can get moved to useEffect

eschutho · 2021-07-26T20:58:27Z

superset-frontend/src/components/ReportModal/index.tsx

+      validator_config_json: {},
+      validator_type: 'operator',
+      working_timeout: 3600,
+      creation_method: 'dashboards',


since we're using a reducer it will be easier if we can let the reducer always hold the state with the correct schema for the api instead of having to rewrite it here.

eschutho · 2021-07-26T22:13:19Z

@lyndsiWilliams @AAfghahi what are we doing for the required field? Do we disable the save button until it's filled out? @yousoph

yousoph · 2021-07-28T04:10:33Z

@lyndsiWilliams @AAfghahi what are we doing for the required field? Do we disable the save button until it's filled out? @yousoph

yes! that works and aligns with the current Alerts & Reports creation

…rset into lyndsi/onsave

eschutho

looks good!

#15856) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat: toggle the ReportModal Icon based on user permissions (#15780) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * added testing props * cleaned up rebase * changed name and type Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * feat: Begin incorporation of email report modal to Charts (#15793) * Add email report modal to Charts * Fix px themes * feat: fetch UI specific reports (#15785) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * created Api call * added click logic * made the fetch report into a action/reducer * abstracted report action * revision * added reportState to reducer * reports conditions * revisions * revisions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * fix: Edit physical dataset from the Edit Dataset modal (#15770) * Remove unnecessary onChange * Remove confliciting onChange * Revert unnecessary change * Enhance and fix tests * feat: add show columns to Reports model (#15712) * added logic for creation_method * revisions * added index * Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py * filters * search columns updated * fix: margin right on warning icon to 8px (#15715) * changed margin right on warning icon to 8px * fixed to grid units from pixels * feat: adding Progress Bar to Benchmark script (#15719) * rough draft of benchmark script * revisions * revisions * rough draft of benchmark script * revisions * Update requirements/development.in Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset/utils/mock_data.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * more revisions Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * fix: migration downgrade references wrong column (#15791) * fix(dashboard): Add resize handles to right and bottom of component (#15778) * fix(dashboard): Add resize handles to right and bottom of component * Fix test * chore: Add tags to the new viz gallery (#15734) * chore: add tags to gallery * fix UT * fix lint * redesign tags filter * chore: change to Highly-used and fix some css * fix UT Co-authored-by: stephenLYZ <750188453@qq.com> * chore: bump 0.17.70 (#15795) * docs: Adding Sunbird to users list (#15794) * chore: Improves the Select component UI/UX - iteration 4 (#15480) * Add z-index only on maximize (#15800) * chore: remove `retry` dependency in favor of `backoff` (#15788) * chore: remove retry dep in favor of backoff * Fix lint * fix: create fk model in benchmark script (#15804) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * Working on onSave functionality * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat: toggle the ReportModal Icon based on user permissions (#15780) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * added testing props * cleaned up rebase * changed name and type Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * feat: fetch UI specific reports (#15785) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * created Api call * added click logic * made the fetch report into a action/reducer * abstracted report action * revision * added reportState to reducer * reports conditions * revisions * revisions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * Dashboard onSave progress * More onSave/create progress * Dashboard POST working! * Dashboard POST relocated to redux * POST now also working in Charts * making linter happy * linter again Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: stellalc7 <stellalc7@gmail.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: stephenLYZ <750188453@qq.com> Co-authored-by: Kumar <kumarks1122@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

lyndsiWilliams and others added 4 commits July 19, 2021 11:43

feat: Begin incorporation of email report modal to Charts (apache#15793)

6a79189

* Add email report modal to Charts * Fix px themes

pull-request-size bot added the size/L label Jul 23, 2021

lyndsiWilliams force-pushed the lyndsi/onsave branch from 731bb45 to 0d072e1 Compare July 26, 2021 16:55

pull-request-size bot added size/XXL and removed size/L labels Jul 26, 2021

lyndsiWilliams marked this pull request as ready for review July 26, 2021 17:10

lyndsiWilliams requested a review from a team as a code owner July 26, 2021 17:10

geido and others added 19 commits July 26, 2021 12:25

fix: Edit physical dataset from the Edit Dataset modal (apache#15770)

c8d5dba

* Remove unnecessary onChange * Remove confliciting onChange * Revert unnecessary change * Enhance and fix tests

feat: add show columns to Reports model (apache#15712)

1561372

* added logic for creation_method * revisions * added index * Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py * filters * search columns updated

fix: margin right on warning icon to 8px (apache#15715)

74e120d

* changed margin right on warning icon to 8px * fixed to grid units from pixels

fix: migration downgrade references wrong column (apache#15791)

5c44960

fix(dashboard): Add resize handles to right and bottom of component (a…

abb464a

…pache#15778) * fix(dashboard): Add resize handles to right and bottom of component * Fix test

chore: Add tags to the new viz gallery (apache#15734)

1a0803e

* chore: add tags to gallery * fix UT * fix lint * redesign tags filter * chore: change to Highly-used and fix some css * fix UT Co-authored-by: stephenLYZ <750188453@qq.com>

chore: bump 0.17.70 (apache#15795)

67edec6

docs: Adding Sunbird to users list (apache#15794)

98e8f06

chore: Improves the Select component UI/UX - iteration 4 (apache#15480)

f1bac8b

Add z-index only on maximize (apache#15800)

797efdd

chore: remove retry dependency in favor of backoff (apache#15788)

a24fcdb

* chore: remove retry dep in favor of backoff * Fix lint

fix: create fk model in benchmark script (apache#15804)

425815e

Working on onSave functionality

7d4ffbd

Dashboard onSave progress

9b43572

lyndsiWilliams added 2 commits July 26, 2021 12:31

More onSave/create progress

d325e8e

Dashboard POST working!

df6acae

lyndsiWilliams force-pushed the lyndsi/onsave branch from b9a9177 to df6acae Compare July 26, 2021 17:32

eschutho force-pushed the selfSubscribeReports branch 2 times, most recently from 69dae2f to b81f120 Compare July 26, 2021 17:53

eschutho force-pushed the selfSubscribeReports branch from b81f120 to cb3896e Compare July 26, 2021 18:04

eschutho force-pushed the selfSubscribeReports branch from cb3896e to b81f120 Compare July 26, 2021 18:08

eschutho force-pushed the lyndsi/onsave branch from df6acae to dfbd723 Compare July 26, 2021 18:32

pull-request-size bot added size/L and removed size/XXL labels Jul 26, 2021

eschutho force-pushed the lyndsi/onsave branch from dfbd723 to 73f8598 Compare July 26, 2021 18:34

eschutho reviewed Jul 26, 2021

View reviewed changes

lyndsiWilliams added 3 commits July 28, 2021 00:21

Dashboard POST relocated to redux

da51d03

POST now also working in Charts

2d0ed0b

Merge branch 'selfSubscribeReports' of https://github.com/apache/supe…

4a757b4

…rset into lyndsi/onsave

lyndsiWilliams force-pushed the lyndsi/onsave branch from 650f9fb to 4a757b4 Compare July 28, 2021 21:14

lyndsiWilliams added 2 commits July 28, 2021 16:25

making linter happy

9bc1065

linter again

3892059

lyndsiWilliams force-pushed the lyndsi/onsave branch from ab617ac to 3892059 Compare July 28, 2021 21:35

eschutho approved these changes Jul 28, 2021

View reviewed changes

eschutho merged commit a6687d3 into apache:selfSubscribeReports Jul 28, 2021

eschutho deleted the lyndsi/onsave branch July 28, 2021 23:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Create/onsave Email Report functionality for Dashboard and Chart #15856

feat: Create/onsave Email Report functionality for Dashboard and Chart #15856

lyndsiWilliams commented Jul 23, 2021

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

eschutho Jul 26, 2021

eschutho Jul 26, 2021

eschutho Jul 26, 2021

eschutho commented Jul 26, 2021

yousoph commented Jul 28, 2021

eschutho left a comment

feat: Create/onsave Email Report functionality for Dashboard and Chart #15856

feat: Create/onsave Email Report functionality for Dashboard and Chart #15856

Conversation

lyndsiWilliams commented Jul 23, 2021

SUMMARY

SCREENSHOT

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

eschutho Jul 26, 2021

Choose a reason for hiding this comment

eschutho Jul 26, 2021

Choose a reason for hiding this comment

eschutho Jul 26, 2021

Choose a reason for hiding this comment

eschutho commented Jul 26, 2021

yousoph commented Jul 28, 2021

eschutho left a comment

Choose a reason for hiding this comment