Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improves the flow to create a new chart #16252

Merged
merged 2 commits into from
Aug 16, 2021
Merged

chore: Improves the flow to create a new chart #16252

merged 2 commits into from
Aug 16, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Improves the flow to create a new chart by adding step indicators, tip messages, and feedback to the user when a step is completed.

#16173 has the full thread of discussion that motivated this PR. Hat tip to @ktmud and @junlincc for the excellent improvement ideas.

Closes #16173
Follow-up of #16200

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-08-13.at.3.41.34.PM.mov
Screen.Recording.2021-08-13.at.3.33.21.PM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member Author

/testenv up

@codecov
Copy link

codecov bot commented Aug 13, 2021 •
edited

Codecov Report

Merging #16252 (c6fcece) into master (720e5b1) will decrease coverage by 0.00%.
The diff coverage is 76.92%.

❗ Current head c6fcece differs from pull request most recent head 2503598. Consider uploading reports for the commit 2503598 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16252      +/-   ##
==========================================
- Coverage   76.73%   76.73%   -0.01%     
==========================================
  Files         997      997              
  Lines       53230    53236       +6     
  Branches     6771     6774       +3     
==========================================
+ Hits        40844    40848       +4     
- Misses      12156    12158       +2     
  Partials      230      230
Flag Coverage Δ
javascript 70.99% <76.92%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
...perset-frontend/src/addSlice/AddSliceContainer.tsx 56.92% <75.00%> (+0.25%) ⬆️
superset-frontend/src/components/Select/Select.tsx 73.42% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720e5b1...2503598. Read the comment docs.

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://34.220.235.176:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas requested a review from ktmud August 13, 2021 19:20
@junlincc
Copy link
Member

Can we add this step check mark to other flow related modal, where requisites are required for proceeding ? like db connection, filter modal maybe?

@rusackas
Copy link
Member

Looking good! I look forward to more usability improvements here yet to come (double-click a viz to create, tabbing to inputs, arrow key navigation, etc). This is a great step toward making the feature more approachable. Nice work!

@michael-s-molina michael-s-molina mentioned this pull request Aug 16, 2021
Merged
8 tasks
rusackas
rusackas approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@michael-s-molina michael-s-molina merged commit 0668eaa into apache:master Aug 16, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

amitmiran137 pushed a commit that referenced this pull request Aug 16, 2021
Merge branch 'master' into feat/extra_strategies
6c9f0fb 
* master:
  chore(pylint): Reenable ungrouped-imports check (#16256)
  chore(pylint): Re-enable super-with-arguments check (#16138)
  fix: disable text reports for now (#16257)
  fix: pivot col names in post_process (#16262)
  chore: Improves the flow to create a new chart (#16252)
  Move pagination outside of table (#16232)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@michael-s-molina
chore: Improves the flow to create a new chart (apache#16252)
a83d98a 
* chore: Improves the flow to create a new chart

* Adds a comment about selector specificity
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@michael-s-molina
chore: Improves the flow to create a new chart (apache#16252)
08ecffd 
* chore: Improves the flow to create a new chart

* Adds a comment about selector specificity
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@pkdotson pkdotson Awaiting requested review from pkdotson

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

@villebro villebro Awaiting requested review from villebro

@ktmud ktmud Awaiting requested review from ktmud

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Gallery] Less-blocking creating new chart flow
5 participants
@michael-s-molina @junlincc @rusackas @pkdotson @mistercrunch