Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pivot col names in post_process #16262

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

This fix some bugs in the pivot table post processing.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #16262 (d4b3d7d) into master (9b2dffe) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16262      +/-   ##
==========================================
- Coverage   76.72%   76.48%   -0.25%     
==========================================
  Files         997      997              
  Lines       53241    53239       -2     
  Branches     6772     6772              
==========================================
- Hits        40849    40718     -131     
- Misses      12162    12291     +129     
  Partials      230      230              
Flag Coverage Δ
hive ?
mysql 81.52% <100.00%> (-0.05%) ⬇️
postgres 81.55% <100.00%> (-0.05%) ⬇️
presto ?
python 81.63% <100.00%> (-0.48%) ⬇️
sqlite 81.19% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/post_processing.py 76.47% <100.00%> (-0.55%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/utils/date_parser.py 93.13% <0.00%> (-3.44%) ⬇️
superset/common/query_context.py 88.88% <0.00%> (-1.86%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.04% <0.00%> (-1.66%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.39%) ⬇️
superset/models/core.py 89.14% <0.00%> (-0.26%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b2dffe...d4b3d7d. Read the comment docs.

@betodealmeida betodealmeida merged commit 542b864 into apache:master Aug 16, 2021
amitmiran137 pushed a commit that referenced this pull request Aug 16, 2021
* master:
  chore(pylint): Reenable ungrouped-imports check (#16256)
  chore(pylint): Re-enable super-with-arguments check (#16138)
  fix: disable text reports for now (#16257)
  fix: pivot col names in post_process (#16262)
  chore: Improves the flow to create a new chart (#16252)
  Move pagination outside of table (#16232)
betodealmeida added a commit to preset-io/superset that referenced this pull request Aug 16, 2021
betodealmeida added a commit to preset-io/superset that referenced this pull request Aug 17, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
@villebro villebro added the v1.3 label Sep 22, 2021
villebro pushed a commit that referenced this pull request Sep 22, 2021
@Kingflyinger
Copy link

rate value totals in pivot table not work as in table.May it be changed in the future?
thanks
image

@villebro
Copy link
Member

Yes, I agree totally with you @Kingflyinger, the "Totals" should use the same aggregation logic as the cell values. This has come up a few times but didn't yet get addressed, and requires some additional logic in the query layer that might take some time to implement (we have to issue a separate query for each layer of totals/subtotals). Do you mind opening an issue here so we can get it prioritized and assigned when the right time comes along?

@Kingflyinger
Copy link

@villebro I opened the issue #16829,and the way it totals means a lot

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/S v1.3 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants