-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate ExploreCtasResultsButton component to typescript #18142
refactor: migrate ExploreCtasResultsButton component to typescript #18142
Conversation
@lyndsiWilliams Can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EugeneTorap this generally looks good. However, you have some linting issues to fix for the CI to pass. Let me know when you update this PR and I'll have a look at it. Thanks!
@geido Can you merge #17939 first and then I will update my PR |
Hello @EugeneTorap the #17939 is now merged. Please resolve your conflicting files and I'll be happy to do another review. Thanks! |
# Conflicts: # superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Codecov Report
@@ Coverage Diff @@
## master #18142 +/- ##
==========================================
- Coverage 66.28% 66.23% -0.05%
==========================================
Files 1605 1605
Lines 62863 62817 -46
Branches 6341 6341
==========================================
- Hits 41666 41606 -60
- Misses 19545 19559 +14
Partials 1652 1652
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://54.212.233.219:8080. Credentials are |
@AAfghahi @lyndsiWilliams Can you review this PR? |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Migrated ExploreCtasResultsButton to TypeScript to apply direction outlined in #18100 .
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION