Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Ocient support #22812

Merged
merged 30 commits into from
Apr 23, 2023
Merged

feat: Add Ocient support #22812

merged 30 commits into from
Apr 23, 2023

Commits on Jan 13, 2023

  1. feat: add OcientEngineSpec

    @jwilliams-ocient
    jwilliams-ocient committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    a8b023c View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. chore: code cleanup 

     * doc: add docstrings to functions
 * chore: clean up comments
 * perf: avoid copying row data that doesn't need to be sanitized
    @jwilliams-ocient
    jwilliams-ocient committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    879f522 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Merge pull request #4 from ocient/user/jwilliams/docstrings 

    chore: code cleanup
    @jwilliams-ocient
    jwilliams-ocient committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e53ef91 View commit details
    Browse the repository at this point in the history

  2. Adding custom errors to Ocient engine spec

    @alexclavel-ocient
    alexclavel-ocient committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9e3ef85 View commit details
    Browse the repository at this point in the history

  3. Fixing syntax regex to match all ocient syntax errors

    @alexclavel-ocient
    alexclavel-ocient committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    818474d View commit details
    Browse the repository at this point in the history

  4. Cleaning up imports

    @alexclavel-ocient
    alexclavel-ocient committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e8c97ba View commit details
    Browse the repository at this point in the history

  5. Merge pull request #5 from ocient/user/aclavel/DB-22258 

    Adding custom errors to Ocient engine spec
    @alexclavel-ocient
    alexclavel-ocient committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    47a7678 View commit details
    Browse the repository at this point in the history

  6. chore: add Ocient dependencies to setup.py (#3)

    @jwilliams-ocient
    jwilliams-ocient committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d465588 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. fix: add missing comma to inline dict element

    @jwilliams-ocient
    jwilliams-ocient committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bee5368 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #7 from ocient/jwilliams-ocient-patch-2

    @alexclavel-ocient
    alexclavel-ocient committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6e773cc View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. test: add unit tests for Ocient engine spec (#6)

    @jwilliams-ocient
    jwilliams-ocient committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ffb76bc View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. DB-23237 Superset: datatypes are not being converted properly (#8) 

    * Fix: Replace invalid inplace type conversion

* Nit: Add comment clarifying why we cannot update in place

* Nit: Generate functions based on cursor, not rows
    @alexclavel-ocient
    alexclavel-ocient committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8059833 View commit details
    Browse the repository at this point in the history

  2. DB-22748 Fix canceling queries in Superset (#2) 

    * Adding support for query cancellation

* Removing double import

* Adding support for query cancellation

Removing double import

Inverting logic for fetch data.

Re-add missing function

* Fiding doubled up merge inputs

* Handle Query cancellation for multiple queries

* Adding mutex lock to query id mapping

* Removing unecesssary iteration over values of cache

* Fixing locks in db engine spec

* Fix error capture in fetch_data
    @alexclavel-ocient
    alexclavel-ocient committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    6c1d956 View commit details
    Browse the repository at this point in the history

  3. Run Black Formatting on Ocient DB Engine Spec (#9)

    @alexclavel-ocient
    alexclavel-ocient committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    6979aed View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. chore: add userdoc for Ocient DB (#10)

    @jwilliams-ocient
    jwilliams-ocient committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a83a363 View commit details
    Browse the repository at this point in the history

  2. fix: rename 'sqlalchemy_ocient' package to 'sqlalchemy-ocient' (#11)

    @jwilliams-ocient
    jwilliams-ocient committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4dd143c View commit details
    Browse the repository at this point in the history

  3. Merge pull request #13 from apache/master 

    Merge apache/master into ocient/master
    @jwilliams-ocient
    jwilliams-ocient committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    b075cc1 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Fix: Update Ocient docs with coorect package name (#14)

    @alexclavel-ocient
    alexclavel-ocient committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    3ab8dff View commit details
    Browse the repository at this point in the history

  2. fix: apply suggestions from pre-commit hooks (#12) 

    * fix: apply suggestions from pre-commit hooks

* fix: correct return type for get_table_names

* fix: correct fetch_data type signature

* fix: fix type annotations within fetch_data body
    @jwilliams-ocient
    jwilliams-ocient committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    75aa069 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Fix: make cte_alias compatible with Ocient (#16) 

    * Fix: make cte_alias compatible with Ocient

* Fixing indentation in ocient.py
    @alexclavel-ocient
    alexclavel-ocient committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    75e4e35 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Adding Ocient to testing requirements (#18)

    @alexclavel-ocient
    alexclavel-ocient committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    4d88c78 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Fix: make fetch_data check for rows properly (#19)

    @alexclavel-ocient
    alexclavel-ocient committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c01ccda View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. build[pyocient]: set min version for pyocient (#20) 

    * v1.0.15 removes upper bound on protobuf version (conflict)
    @jwilliams-ocient
    jwilliams-ocient committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1f1c5a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. docs: add example of setting DSN params (#21) 

    * docs: add example of setting DSN params

* docs: apply review suggestions

Co-authored-by: rmasters1 <100157128+rmasters1@users.noreply.github.com>

---------

Co-authored-by: rmasters1 <100157128+rmasters1@users.noreply.github.com>
    @jwilliams-ocient @rmasters1
    jwilliams-ocient and rmasters1 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    30b13e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. fix: recover from pyocient import errors. The library may not be inst… 

    …alled on the target host (#22)
    @jwilliams-ocient
    jwilliams-ocient committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b2ba77d View commit details
    Browse the repository at this point in the history

  2. fix: forgot to remove the unchecked imports at the top of the file...

    @jwilliams-ocient
    jwilliams-ocient committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    33891c4 View commit details
    Browse the repository at this point in the history

  3. chore: remove potentially unknown type annotations

    @jwilliams-ocient
    jwilliams-ocient committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3f802d8 View commit details
    Browse the repository at this point in the history

  4. chore: add epoch_to_dttm override

    @jwilliams-ocient
    jwilliams-ocient committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d4a4d0b View commit details
    Browse the repository at this point in the history

  5. test: fix broken unit tests (#23) 

    * refactor: holy shit I botched another commit lol

* fix: address warnings generated by pylint

* fix: fix custom errors matchers

* test: fix broken unit tests
    @jwilliams-ocient
    jwilliams-ocient committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    787e303 View commit details
    Browse the repository at this point in the history

  6. chore: pass pre-commit checks (#24) 

    * style: run pre-commit hooks

* style: remove type annotations that may not exist

* build: remove ocient from requirements/testing.in
    @jwilliams-ocient
    jwilliams-ocient committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e82386e View commit details
    Browse the repository at this point in the history