Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: do not mark helm releases as github latest #26753

Merged
merged 1 commit into from
Jan 23, 2024
Merged

chore: do not mark helm releases as github latest #26753

merged 1 commit into from
Jan 23, 2024

Conversation

eschutho
Copy link
Member

SUMMARY

When a helm release is auto-generated, it is being marked as "latest" in github. We'd prefer to keep the latest release as the official Superset release instead.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho marked this pull request as ready for review January 23, 2024 01:47
michael-s-molina
michael-s-molina approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eschutho eschutho merged commit 14c3e2b into apache:master Jan 23, 2024
47 checks passed
@eschutho eschutho deleted the elizabeth/fix-helm-release branch January 23, 2024 18:09
rusackas pushed a commit that referenced this pull request Jan 24, 2024
@eschutho @rusackas
chore: do not mark helm releases as github latest (#26753)
09f0a06
eschutho added a commit to preset-io/superset that referenced this pull request Jan 31, 2024
@eschutho
chore: do not mark helm releases as github latest (apache#26753)
538036f
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@eschutho @sfirke
chore: do not mark helm releases as github latest (apache#26753)
f064c27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
@michael-s-molina michael-s-molina mentioned this pull request May 14, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@geido geido geido approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eschutho @betodealmeida @geido @michael-s-molina @mistercrunch