Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Don't mark Helm releases as latest #28498

Merged
merged 1 commit into from
May 14, 2024
Merged

chore: Don't mark Helm releases as latest #28498

merged 1 commit into from
May 14, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

#26753 set mark_as_latest: false in our Helm release workflow in an attempt to stop Helm releases from being tagged as latest. The problem is that our version of chart-releaser-action is 1.2.0 which does not support that configuration. mark_as_latest was introduced in version 1.6.0 and this PR bumps that dependency to match this version.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label May 14, 2024
@dosubot dosubot bot added the deploy:helm label May 14, 2024
@michael-s-molina michael-s-molina changed the title chore: Don't mark Helm releases as latest chore: Don't tag Helm releases as latest May 14, 2024
@michael-s-molina michael-s-molina changed the title chore: Don't tag Helm releases as latest chore: Don't mark Helm releases as latest May 14, 2024
@michael-s-molina michael-s-molina merged commit 964202a into apache:master May 14, 2024
36 of 37 checks passed
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@michael-s-molina @jzhao62
chore: Don't mark Helm releases as latest (apache#28498)
0b1f60d
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@michael-s-molina @EnxDev
chore: Don't mark Helm releases as latest (apache#28498)
1536333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
deploy:helm github_actions Pull requests that update GitHub Actions code size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-s-molina @craig-rueda