fix: docker ephemeral environment, push only on testenv comment #26473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley and
kgabryje
as code owners
|
/testenv |
1 similar comment
|
/testenv |
rusackas
added
the
review:checkpoint
john-bodley
removed
the
review:checkpoint
|
/testenv up |
|
@dpgaspar Ephemeral environment creation is currently limited to committers. |
dpgaspar
changed the title
geido
reviewed
Jan 22, 2024
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
geido
approved these changes
Jan 23, 2024
rusackas
pushed a commit
that referenced
this pull request
Jan 24, 2024
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
| const artifacts = await github.actions.listWorkflowRunArtifacts({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| run_id: ${{ github.event.workflow_run.id }}, |
There was a problem hiding this comment.
hey @dpgaspar this change broke the ephemeral envs because the context is different. Before the trigger was a workflow_run, and now being comment created this property is not available in this context.
9 tasks
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 31, 2024
…he#26473) Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
…he#26473) Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently docker ephemeral env (https://github.com/apache/superset/blob/master/.github/workflows/docker-ephemeral-env.yml) triggers when docker workflow finishes, this changes moves this step to when an actual committer requests for a docker env to be created. Both workflows triggers have
secretsaccess butissue_commentuses current default branch commit SHA so it's no subject to PR changes and validates that only privilege users can execute this step.I was not able to properly test this change since it run with current master git SHA, so I expect that further changes may be needed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION