Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove ephemeral docker build from required workflow #26917

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix: remove ephemeral docker build from required workflow #26917

merged 1 commit into from
Jan 31, 2024

Conversation

dpgaspar
Copy link
Member

SUMMARY

Removes ephemeral-docker-build from a required workflow to unblock this PR: #26852 that is removing it

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar merged commit 5172e25 into apache:master Jan 31, 2024
31 checks passed
@dpgaspar dpgaspar deleted the fix/remove-ephemeral-requirement branch January 31, 2024 12:01
@dpgaspar dpgaspar mentioned this pull request Jan 31, 2024
Merged
9 tasks
@mistercrunch
Copy link
Member

Ooops that was my bad ... kinda, there was a few conflicts here and confusion. I'm fixing a conflict in here now -> https://github.com/apache/superset/pull/26923/files#diff-5c944a9ac8058c2c0c5c36c4cae50d1bf55f897ca9776d196477b6b83332555eR120

Reusing the python script for docker building should make things better, use cache, standardize the tagging, ...

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@dpgaspar @sfirke
fix: remove ephemeral docker build from required workflow (apache#26917)
ae212a2
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@dpgaspar
fix: remove ephemeral docker build from required workflow (apache#26917)
8acbe9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @mistercrunch @geido