THRIFT-4446: JSONProtocol Base64 Encoding: Do not trim padding on enc…

…ode. Client: csharp Client: netcore This closes #1463
apache · Jan 11, 2018 · d066fa8 · d066fa8
1 parent d3355af
commit d066fa8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/lib/csharp/src/Protocol/TJSONProtocol.cs b/lib/csharp/src/Protocol/TJSONProtocol.cs
@@ -544,11 +544,6 @@ private void WriteJSONBase64(byte[] b)
             int len = b.Length;
             int off = 0;
 
-            // Ignore padding
-            int bound = len >= 2 ? len - 2 : 0;
-            for (int i = len - 1; i >= bound && b[i] == '='; --i) {
-                --len;
-            }
             while (len >= 3)
             {
                 // Encode 3 bytes at a time

diff --git a/lib/netcore/Thrift/Protocols/TJSONProtocol.cs b/lib/netcore/Thrift/Protocols/TJSONProtocol.cs
@@ -384,14 +384,6 @@ private async Task WriteJsonBase64Async(byte[] b, CancellationToken cancellation
             var len = b.Length;
             var off = 0;
 
-            // Ignore padding
-            var bound = len >= 2 ? len - 2 : 0;
-
-            for (var i = len - 1; i >= bound && b[i] == '='; --i)
-            {
-                --len;
-            }
-
             while (len >= 3)
             {
                 // Encode 3 bytes at a time
@@ -1167,4 +1159,4 @@ public async Task<byte> PeekAsync(CancellationToken cancellationToken)
             }
         }
     }
-}
+}