THRIFT-4446: JSONProtocol Base64 Encoding: Do not trim padding on encode. #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the C# and .NET Core libraries, the JSONProtocol's Binary Encoding to Base64 trims padding from the user provided byte arrays before encoding into base64. This behaviour is incorrect, as the user provided bytes should be encoded exactly as they are provided. Otherwise, data may be lost. - Fixed by no longer trimming padding on encode.
license-fn
changed the title
jeking3
approved these changes
Jan 11, 2018
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Mar 10, 2018
…ode. Client: csharp Client: netcore This closes apache#1463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the C# and .NET Core libraries, the JSONProtocol's Binary Encoding to Base64 trims padding from the user provided byte arrays before encoding into Base64. This behavior is incorrect, as the user provided data should be encoded exactly as provided. Otherwise, data may be lost.
Fixed by no longer trimming padding on encode. Padding must still be trimmed on decode, in accordance with the Base64 specification.
For example:
[0x01, 0x3d, 0x3d]yields[0x01]upon decode. This is incorrect, as I should decode the exact data that I encoded.[0x01, 0x3d, 0x3d], as expected.