THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with include_directories() #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nclude_directories() This allows us to avoid issues where there are no paths to be added to the include path (include_directories() errors when given an empty string). Specifically, gcc-6 requires that libraries stop passing paths like '/usr/include' (or they will get libstdc++ build errors), so these paths will be empty more often in the future.
|
I couldn't reproduce this using GCC 6 and boost headers in /usr/include. |
|
Issue was observed in yocto (aka open-embedded) when building for target. It likely requires cross compilation (and thus /usr/include is actually some other path) to trigger. |
|
@jfarrell the Jira ticket was resolved as "Won't Fix" here; can you close this PR? Thanks. |
|
@jfarrell the Jira ticket was resolved as "Won't Fix" here; can you close this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to avoid issues where there are no paths to be added to
the include path (include_directories() errors when given an empty
string).
Specifically, gcc-6 requires that libraries stop passing paths like
'/usr/include' (or they will get libstdc++ build errors), so these paths
will be empty more often in the future.