Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with include_directories() #1082

Closed
wants to merge 1 commit into from
Closed

THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with include_directories() #1082

wants to merge 1 commit into from

Commits on Sep 7, 2016

  1. THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with i… 

    …nclude_directories()

This allows us to avoid issues where there are no paths to be added to
the include path (include_directories() errors when given an empty
string).

Specifically, gcc-6 requires that libraries stop passing paths like
'/usr/include' (or they will get libstdc++ build errors), so these paths
will be empty more often in the future.
    @codyps
    codyps committed Sep 7, 2016
    Configuration menu
    Copy the full SHA
    b0c5e8c View commit details
    Browse the repository at this point in the history