Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-4007: TTransport.py micro-optimization: don't call len(chunk) twice #1121

Closed
wants to merge 1 commit into from

Conversation

ndjensen
Copy link

@ndjensen ndjensen commented Nov 1, 2016

No description provided.

@Jens-G
Copy link
Member

Jens-G commented Nov 12, 2016

Thanks!
Could you also create a JIRA ticket according to our contrib guidelines?

@Jens-G
Copy link
Member

Jens-G commented Nov 15, 2016

Ping @ndjensen

1 similar comment
@Jens-G
Copy link
Member

Jens-G commented Dec 3, 2016

Ping @ndjensen

@ndjensen ndjensen changed the title TTransport.py micro-optimization: don't call len(chunk) twice THRIFT-4007: TTransport.py micro-optimization: don't call len(chunk) twice Dec 15, 2016
@ndjensen
Copy link
Author

Sorry for the delay. https://issues.apache.org/jira/browse/THRIFT-4007

@jeking3
Copy link
Contributor

jeking3 commented Jan 28, 2017

Hello - please rebase on master and force push. I would like to see a CI build pass before merging; save perhaps job #17 which has been failing.

@asfgit asfgit closed this in de9c330 Feb 1, 2017
jeking3 added a commit to jeking3/thrift that referenced this pull request Nov 30, 2017
…twice

Client: Python
Patch: Nate Jensen <nathan.jensen@raytheon.com>

This closes apache#1121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants