THRIFT-4069: perl library cleanup - namespaces, versioning, exception fixes #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeking3
force-pushed
the
THRIFT-4069
branch
3 times, most recently
from
1a1a4a2
to
9d2254d
Compare
jeking3
commented
Mar 27, 2017
build/docker/centos/Dockerfile
Outdated
| perl-IO-Socket-SSL \ | ||
| perl-Net-SSLeay \ | ||
| perl-Crypt-SSLeay |
There was a problem hiding this comment.
I have reverted this change locally, since both SSLeay modules are needed for SSL/TLS sockets and for Http(s)Client transport. When I merge upstream I will drop the changes to this file.
jeking3
commented
Mar 27, 2017
build/docker/debian/Dockerfile
Outdated
| @@ -157,7 +157,7 @@ ENV PATH /usr/local/go/bin:$PATH | |||
|
|
|||
| # Haxe | |||
| RUN mkdir -p /usr/lib/haxe && \ | |||
| curl http://haxe.org/website-content/downloads/3.2.0/downloads/haxe-3.2.0-linux64.tar.gz | \ | |||
| wget -O - https://github.com/HaxeFoundation/haxe/releases/download/3.4.2/haxe-3.4.2-linux64.tar.gz | \ | |||
There was a problem hiding this comment.
haxe 3.2.0 is no longer available for download, and I needed to build a local image to identify build issues.
There was a problem hiding this comment.
Will wait for THRIFT-4141 and merge out the Dockerfile change from this pull request.
jeking3
added a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
… fixes Client: perl This closes apache#1220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.