THRIFT-4264: Fix PHP tests requiring sockets.so #1315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures seems unrelated, how do we retrigger em to be run again? |
|
Rebased on top of master to trigger tests to be run again. |
norrs
force-pushed
the
THRIFT-4264
branch
2 times, most recently
from
0200514
to
7884dab
Compare
|
@norrs now that the CI builds have been stabilized, if you could rebase on master and refresh this PR, we'll try to get a clean build out of it. |
The PHP library requires sockets.so for the socket_import_stream() function. Make it available for the tests by symlinking in the module. Patch: Håkon Hitland <hakon.hitland@zedge.net> This closes #4264
|
@jeking3 : Done; let's see how it goes this time. |
jeking3
approved these changes
Sep 22, 2017
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
Client: php This closes apache#1315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP library requires sockets.so for the socket_import_stream() function.
Make it available for the tests by symlinking in the module.
Patch: Håkon Hitland hakon.hitland@zedge.net
This closes #4264