THRIFT-4423 migrate to psr-4 #1445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robberphex
changed the title
robberphex
force-pushed
the
psr-4
branch
4 times, most recently
from
4b6beeb
to
caf2ead
Compare
jeking3
requested changes
Dec 28, 2017
build/docker/run.sh
Outdated
| @@ -25,6 +25,8 @@ DOCKER_TAG=$DOCKER_REPO:$DISTRO | |||
|
|
|||
| printenv | sort | |||
|
|
|||
| composer install | |||
There was a problem hiding this comment.
This looks like it should be part of the php section of the Dockerfile. By putting it in the run section, we run "composer install" on the host and then start a docker environment which doesn't have access to it.
build/docker/scripts/sca.sh
Outdated
| @@ -56,7 +56,3 @@ echo TODOs: `grep -r TODO * | wc -l` | |||
|
|
|||
| # LoC | |||
| sloccount . | |||
|
|
|||
| # System Info | |||
There was a problem hiding this comment.
Removing these lines looks unrelated to the task at hand, and they don't take much time, and they provide useful info.
lib/php/test/Makefile.am
Outdated
| @@ -17,6 +17,8 @@ | |||
| # under the License. | |||
| # | |||
|
|
|||
| PHPUNIT=./../../../vendor/bin/phpunit | |||
There was a problem hiding this comment.
Is this relative path going to work on every platform?
jeking3
approved these changes
Dec 28, 2017
robberphex
force-pushed
the
psr-4
branch
3 times, most recently
from
751f8fd
to
ae3b4fe
Compare
|
I'll watch for a passing build, and then merge tomorrow if it's good. |
|
That pesky concurrency test! Not related to this. |
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Mar 10, 2018
Client: php This closes apache#1445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://issues.apache.org/jira/browse/THRIFT-4423