Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-4464: Fix typo in TNonblockingServer.py #1475

Closed
wants to merge 1 commit into from

Conversation

tomtung
Copy link
Contributor

@tomtung tomtung commented Jan 19, 2018

No description provided.

@jeking3
Copy link
Contributor

jeking3 commented Jan 24, 2018

It would be helpful if someone with python experience could double-check this.

@allengeorge
Copy link
Contributor

On the face of it that looks correct. There isn't even a message in scope, so when it hits that line the code would just break. I'll look a little deeper.

@nsuke
Copy link
Member

nsuke commented Jan 24, 2018

Thanks @tomtung, looks fine to me.

@asfgit asfgit closed this in 00646bb Jan 24, 2018
jeking3 pushed a commit to jeking3/thrift that referenced this pull request Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants