-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undeclared statusCode variable #1531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please amend your commit message to begin with the Jira ticket ID, for example:
THRIFT-3926: fix undeclared statusCode variable
Client: nodejs
I used the github squash and merge tool to fix the commit message to conform to project requirements. Thanks. |
Thank you @jeking3! |
How often do you guys publish new versions? Is there a chance to have it in the npm sometimes soon? |
Language-specific distribution is spotty. For example I do perl cpan updates myself. It looks like we regularly publish; I'm not sure when we're going to start the 0.12.0 release cycle but I know we want more frequent releases than we've done in the past. |
Any updates on the 0.12.0 release? We'd like to move away from referencing a specific commit to using an official version. Anything I can help with? |
@NameFILIP looks like we dropped the ball this year again, but thank you for being persistent here, because it's needed. @jfarrell we need a long term solution to getting multiple releases out the door yearly. We should be able to release quarterly with automation or at least twice yearly even with a manual process. cc: @jensg - I think this can be done entirely through CI automation by leveraging a branch with a With @allengeorge working on exorcising the build demons in |
Thanks for the follow up @allengeorge! Do the language framework releases have to be atomic? For example node patches can go out and get published to npm at a much more frequent cadence when such patch releases are necessary. |
Hello. Also running into this in an issue of ours. Any chance we could get a new release kicked off? All the best, |
@lxe to date the project has only made monolithic releases. I understand the importance of having language-specific patches however, and after the 0.12.0 release we'll look into doing that. |
statusCode
on the line 173 is an undeclared variable. It crashes the node server.