Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undeclared statusCode variable #1531

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Conversation

NameFILIP
Copy link
Contributor

@NameFILIP NameFILIP commented Apr 3, 2018

statusCode on the line 173 is an undeclared variable. It crashes the node server.

Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please amend your commit message to begin with the Jira ticket ID, for example:

THRIFT-3926: fix undeclared statusCode variable
Client: nodejs

@jeking3 jeking3 merged commit 63b75d9 into apache:master Apr 6, 2018
@jeking3
Copy link
Contributor

jeking3 commented Apr 6, 2018

I used the github squash and merge tool to fix the commit message to conform to project requirements. Thanks.

@NameFILIP
Copy link
Contributor Author

Thank you @jeking3!

@NameFILIP
Copy link
Contributor Author

How often do you guys publish new versions? Is there a chance to have it in the npm sometimes soon?

@jeking3
Copy link
Contributor

jeking3 commented Apr 7, 2018

Language-specific distribution is spotty. For example I do perl cpan updates myself. It looks like we regularly publish; I'm not sure when we're going to start the 0.12.0 release cycle but I know we want more frequent releases than we've done in the past.

@NameFILIP
Copy link
Contributor Author

Any updates on the 0.12.0 release? We'd like to move away from referencing a specific commit to using an official version. Anything I can help with?

@jeking3
Copy link
Contributor

jeking3 commented Nov 15, 2018

@NameFILIP looks like we dropped the ball this year again, but thank you for being persistent here, because it's needed.

@jfarrell we need a long term solution to getting multiple releases out the door yearly. We should be able to release quarterly with automation or at least twice yearly even with a manual process. cc: @jensg - I think this can be done entirely through CI automation by leveraging a branch with a release/ prefix which kicks off different jobs, including automation of the build numbers across all the languages package descriptions, and eventually a job that can build and publish to package managers automatically.

With @allengeorge working on exorcising the build demons in cl and d so that our CI build can be more stable (I'm regularly re-kicking individual jobs to work around known issues), I can work on release automation. I'll look through the backlog to see if there is an entry for this, and if not I will add it.

@lxe
Copy link

lxe commented Dec 5, 2018

Thanks for the follow up @allengeorge! Do the language framework releases have to be atomic? For example node patches can go out and get published to npm at a much more frequent cadence when such patch releases are necessary.

@vicapow
Copy link

vicapow commented Dec 5, 2018

Hello. Also running into this in an issue of ours. Any chance we could get a new release kicked off?

All the best,
Victor

romaxa pushed a commit to romaxa/thrift that referenced this pull request Dec 5, 2018
@jeking3
Copy link
Contributor

jeking3 commented Dec 6, 2018

@lxe to date the project has only made monolithic releases. I understand the importance of having language-specific patches however, and after the 0.12.0 release we'll look into doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants