THRIFT-4845: Stop ignoring small timeouts #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build seems to have failed in the Haskell build for some reason. I'll rebase this after that issue is resolved. |
jeking3
requested changes
May 12, 2019
Client: php CURLOPT_TIMEOUT requires a long [0], so it seems that small values like 0.2 are being rounded to 0, resulting in a lack of any timeout. This change uses CURLOPT_TIMEOUT_MS, which the PHP documentation says was "added in cURL 7.16.2. Available since PHP 5.2.3." [0] https://curl.haxx.se/libcurl/c/CURLOPT_TIMEOUT.html
|
I rebased this on master. One of the tests failed, though I'm not sure I see why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client: php
CURLOPT_TIMEOUT requires a long [0], so it seems that small values
like 0.2 are being rounded to 0, resulting in a lack of any timeout.
This change uses CURLOPT_TIMEOUT_MS, which the PHP documentation
says was "added in cURL 7.16.2. Available since PHP 5.2.3."
[0] https://curl.haxx.se/libcurl/c/CURLOPT_TIMEOUT.html