THRIFT-4914: Add THeader to context object for server reads #1840
Conversation
lib/go/thrift/header_context.go
Outdated
| ) | ||
|
|
||
| // SetContextHeader sets a header in the context. | ||
| func SetContextHeader(ctx context.Context, key, value string) context.Context { |
There was a problem hiding this comment.
SetHeader sounds better, no need to mention Context in the function name. Same goes for all the other functions in this file.
There was a problem hiding this comment.
@dcelasun My main concern is that we have functions sound similar, like thrift.(*THeaderProtocol).SetWriteHeader. Although there's no conflicts this might look confusing and making it more explicit might be better. Thoughts?
There was a problem hiding this comment.
I did it in a fixup commit. If we decided that we do want the rename I'll squash the branch.
There was a problem hiding this comment.
Since the other functions belong to THeaderProtocol and these new ones are on the package level, I don't think there'll be much confusion.
If you have any other changes you'd like to do, please go ahead. Otherwise I'm gonna squash & merge.
There was a problem hiding this comment.
I squashed them. Thanks for the review!
Client: go This is the first part of THRIFT-4914, which handles the server reading part in the requests (client -> server direction). In TSimpleServer implementation, when the protocol is THeaderProtocol, auto add all the headers read into the context object before passing that to processor, so the processor code can access them from the context object directly, via the new helper functions added in header_context.go file.
fishy
force-pushed
the
theader-context-server-read
branch
from
ac643f1
to
1ff225d
Compare
Client: go
This is the first part of THRIFT-4914, which handles the server reading
part in the requests (client -> server direction).
In TSimpleServer implementation, when the protocol is THeaderProtocol,
auto add all the headers read into the context object before passing
that to processor, so the processor code can access them from the
context object directly, via the new helper functions added in
header_context.go file.
[skip ci]at the end of your pull request to free up build resources.