Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5225: Use nullptr instead of NULL #2168

Closed
wants to merge 1 commit into from
Closed

THRIFT-5225: Use nullptr instead of NULL #2168

wants to merge 1 commit into from

Conversation

zeshuai007
Copy link
Member

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@emmenlau
Copy link
Member

emmenlau commented Jun 3, 2020

Looks good to me.

@zeshuai007 zeshuai007 force-pushed the THRIFT-5225 branch 4 times, most recently from cf6bfbb to 94e5545 Compare June 3, 2020 14:32
@Jens-G
Copy link
Member

Jens-G commented Jun 12, 2020

This needs a rebase, could you do that please?

@zeshuai007
Copy link
Member Author

@Jens-G , of course, done.

@Jens-G Jens-G closed this in 26681fb Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeshuai007 @emmenlau @Jens-G