Up-Integrate of pomack's Thrift support for the Go language: #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removal of extraneous pre-Golang Version 1 build infrastructure, namely the make files. - Inclusion of compiler and runtime libraries from commit d1134697a88f09924befae4cd994632db8c31545. I have additional improvements I want to make to Thrift's Golang support, so I just want to get things more current before submitting them.
keynslug
added a commit
to keynslug/thrift
that referenced
this pull request
Aug 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have additional improvements I want to make to Thrift's Golang support, so I just want to get
things more current before submitting them.
The base for the changes comes from https://github.com/pomack/thrift4go. This should help remedy https://issues.apache.org/jira/browse/THRIFT-1600.