Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5564: setup compiler-building github action [skip ci] #2592

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Apr 28, 2022

setup a basic github action. this is part of THRIFT-5564 but does not completely close it yet.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jimexist jimexist changed the title setup example github action THRIFT-5564: setup example github action Apr 28, 2022
@jimexist
Copy link
Member Author

cc @Jens-G i guess this needs to be enabled after the merge - for now i can't see from the actions tab whether it's working or not

@ctubbsii
Copy link
Member

cc @Jens-G i guess this needs to be enabled after the merge - for now i can't see from the actions tab whether it's working or not

You should be able to see if it's working in your fork.

@jimexist
Copy link
Member Author

cc @Jens-G i guess this needs to be enabled after the merge - for now i can't see from the actions tab whether it's working or not

You should be able to see if it's working in your fork.

thanks for the pointer - it's https://github.com/Jimexist/thrift/actions/runs/2237581561 and working for now

@jimexist
Copy link
Member Author

cc @Jens-G i guess this needs to be enabled after the merge - for now i can't see from the actions tab whether it's working or not

You should be able to see if it's working in your fork.

thanks for the pointer - it's https://github.com/Jimexist/thrift/actions/runs/2237581561 and working for now

with that passed i plan to leave this pull request as is and put future work in subsequent pull requests to make the change / shift incremental.

my current plan is to have several steps:

  1. enable thrift compiler building in ubuntu (this PR)
  2. enable thrift compiler building in macOS and windows
  3. use artifact sharing to share the pre-built compiler, and create subsequent library building workflows per language - this is unlike the current setup in travis where a monolithic docker environment has to be setup
  4. if that goes smoothly, have a final cross test runner that combines all the built cross test runners

@jimexist jimexist changed the title THRIFT-5564: setup example github action THRIFT-5564: setup compiler-building github action Apr 28, 2022
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only partially accomplishes the task described in the JIRA. But, I think that's okay, because you need the GitHub Actions to be enabled, which this will do, in order to validate future changes that are more complex. However, this needs to run on PRs as well as push, in order to be useful.

.github/workflows/build_compiler.yml Outdated Show resolved Hide resolved
@jimexist
Copy link
Member Author

jimexist commented Apr 28, 2022

@ctubbsii thanks for the review - i guess it's turned on now 🏁

@jimexist jimexist changed the title THRIFT-5564: setup compiler-building github action THRIFT-5564: setup compiler-building github action [skip ci] Apr 28, 2022
@ctubbsii ctubbsii merged commit 6a61c4e into apache:master Apr 28, 2022
@jimexist jimexist deleted the setup-github-action branch April 29, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants