THRIFT-5584: use gradle toolchain to specify Java 11 with --release 8

[jimexist]

use gradle toolchain to specify Java 11 with --release 8

• Did you create an Apache Jira ticket? (not required for trivial changes)
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

[ctubbsii]

Looks good to me, for the most part. I would suggest a slight change to the error message.

Also, there are some conditionals in the Gradle build files that check for Java 11. Those can be removed now.

We'd also need to remove the CI checks that run using JDK 8, like that the Ubuntu Xenial builds, unless you want to restore your previous workaround to force JDK 11 to be installed.

[jimexist]

Looks good to me, for the most part. I would suggest a slight change to the error message.

Also, there are some conditionals in the Gradle build files that check for Java 11. Those can be removed now.

We'd also need to remove the CI checks that run using JDK 8, like that the Ubuntu Xenial builds, unless you want to restore your previous workaround to force JDK 11 to be installed.

we don't need to update the xenial build, since using java toolchain means we are decoupling the JDK used to run gradle from the one used to compile Java. in the case of xenial, JDK8 is used to run gradle, which will download JDK 11 on its own before compiling Java.

[ctubbsii]

we don't need to update the xenial build, since using java toolchain means we are decoupling the JDK used to run gradle from the one used to compile Java. in the case of xenial, JDK8 is used to run gradle, which will download JDK 11 on its own before compiling Java.

Ah, ok. That's convenient. I assumed it worked like Maven toolchains: detected but not installed.

[jimexist]

we don't need to update the xenial build, since using java toolchain means we are decoupling the JDK used to run gradle from the one used to compile Java. in the case of xenial, JDK8 is used to run gradle, which will download JDK 11 on its own before compiling Java.

Ah, ok. That's convenient. I assumed it worked like Maven toolchains: detected but not installed.

yes there's a section in here describing the auto provisioning feature in case you are interested

[slachiewicz]

why not split dependency updates or other code changes - not related to Gradle/Java update from real Gradle Java 11 upgrade?

[ctubbsii]

why not split dependency updates or other code changes - not related to Gradle/Java update from real Gradle Java 11 upgrade?

If they are small and trivial, like these, I don't think it matters much. All of these are related to updating the build.

[nicolasb29]

Hi,

It seems that the version 0.18 is compiled in Java 11 even if --release 8 is present :

• libthrift 0.18 :
  javap -verbose org/apache/thrift/transport/THttpClient.class | grep -i major
  major version: 55
• libthrift 0.17 :
  javap -verbose org/apache/thrift/transport/THttpClient.class | grep -i major
  major version: 52

https://javaalmanac.io/bytecode/versions/

[ctubbsii]

@nicolasb29 That's not a bug. Thrift moved to Java 11 in #2686 (THRIFT-5644)