THRIFT-5502: Log SocketException at WARN level only #2608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? |
|
instead of the private method isIgnorableException we can just have a method to log proper message and add mentioned in THRIFT-5502 ignore for specific Socket exceptions. |
I misunderstood this. I thought you were removing duplicate code and consolidating into a single method, but it didn't make sense, since this code is only called once. What you're actually doing is combining the exception handling logic, so it's all handled in one place. That makes sense to me now. |
africamonkey
pushed a commit
to africamonkey/thrift
that referenced
this pull request
Sep 14, 2022
Client: java Patch: Sylwester Lachiewicz & Christopher Tubbs This closes apache#2608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and proposition to move logging to one place