Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[THRIFT-5752] Add TTransportFactoryInterface #2917

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

sveneld
Copy link
Contributor

@sveneld sveneld commented Jan 6, 2024

I'm offer to add TTransportFactoryInterface for having a possibility to use own implementation of TTransportFactory in TServer.

I have a problem when I'm tried to make a TSimpleServer for client who used a
TFramedTransport. Current realization of TTransportFactory does not give me a possibility to add a TFramedTransport as a decorator for use TTransport

  • https://issues.apache.org/jira/browse/THRIFT-5752
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G added the php label Jan 6, 2024
@Jens-G
Copy link
Member

Jens-G commented Jan 6, 2024

How would compatibility affected? Does that change break existing code? If so, can we prevent that?

@sveneld
Copy link
Contributor Author

sveneld commented Jan 7, 2024

Combability should not be affected. Class TTransportFactory used only for creation of TServer.
I am just added an Interface for it, and replace all places of usage from TTransportFactory to TTransportFactoryInterface.
It should work fine.

@Jens-G Jens-G merged commit c2738d0 into apache:master Jan 9, 2024
17 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants