Skip to content

Commit

Permalink
Fixed ProfileExportResponse struct to remove undocumented alerts fiel…
Browse files Browse the repository at this point in the history
…d. (#7917)

* Fixed ProfileExportResponse struct to remove undocumented alerts field.

* Updated changelog

* Fixed tests
  • Loading branch information
rimashah25 committed Jan 22, 2024
1 parent 1ba18fc commit a8c0a5d
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Updated the CacheGroups Traffic Portal page to use a more performant AG-Grid-based table.

### Fixed
- [#7917](https://github.com/apache/trafficcontrol/pull/7917) *Traffic Ops* Removed `Alerts` field from struct `ProfileExportResponse`.
- [#7918](https://github.com/apache/trafficcontrol/pull/7918) *Traffic Portal* Fixed topology link under DS-Servers tables page
- [#7846](https://github.com/apache/trafficcontrol/pull/7846) *Traffic Portal* Increase State character limit

Expand Down
2 changes: 0 additions & 2 deletions lib/go-tc/profiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,6 @@ type ProfileExportResponse struct {
// Parameters associated to the profile
//
Parameters []ProfileExportImportParameterNullable `json:"parameters"`

Alerts
}

// ProfileImportRequest is an object of the form used by Traffic Ops
Expand Down
2 changes: 1 addition & 1 deletion traffic_ops/testing/api/v3/profiles_export_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func TestProfilesExport(t *testing.T) {
t.Run(name, func(t *testing.T) {
resp, reqInf, err := testCase.ClientSession.ExportProfile(testCase.EndpointID())
for _, check := range testCase.Expectations {
check(t, reqInf, resp, resp.Alerts, err)
check(t, reqInf, resp, tc.Alerts{}, err)
}
})
}
Expand Down
2 changes: 1 addition & 1 deletion traffic_ops/testing/api/v4/profiles_export_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func TestProfilesExport(t *testing.T) {
t.Run(name, func(t *testing.T) {
resp, reqInf, err := testCase.ClientSession.ExportProfile(testCase.EndpointID(), testCase.RequestOpts)
for _, check := range testCase.Expectations {
check(t, reqInf, resp, resp.Alerts, err)
check(t, reqInf, resp, tc.Alerts{}, err)
}
})
}
Expand Down
2 changes: 1 addition & 1 deletion traffic_ops/testing/api/v5/profiles_export_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func TestProfilesExport(t *testing.T) {
t.Run(name, func(t *testing.T) {
resp, reqInf, err := testCase.ClientSession.ExportProfile(testCase.EndpointID(), testCase.RequestOpts)
for _, check := range testCase.Expectations {
check(t, reqInf, resp, resp.Alerts, err)
check(t, reqInf, resp, tc.Alerts{}, err)
}
})
}
Expand Down

0 comments on commit a8c0a5d

Please sign in to comment.