Remove inline topology comment from parent.config generation (#5376)

ATS doesn't support inline comments in parent.config.

(cherry picked from commit df92555)

CHANGELOG.md

@@ -137,6 +137,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - #5069 - For LetsEncryptDnsChallengerWatcher in Traffic Router, the cr-config location is configurable instead of only looking at `/opt/traffic_router/db/cr-config.json`
 - #5191 - Error from IMS requests to /federations/all
 - Fixed Astats csv issue where it could crash if caches dont return proc data
+- Fixed parent.config generation for topology-based delivery services (inline comments not supported)
 
 ### Changed
 - Changed some Traffic Ops Go Client methods to use `DeliveryServiceNullable` inputs and outputs.

lib/go-atscfg/parentdotconfig.go

@@ -761,7 +761,6 @@ func getTopologyParentConfigLine(
 	txt += ` qstring=` + getTopologyQueryString(ds, serverParams, serverPlacement.IsLastCacheTier, dsParams.Algorithm, dsParams.QueryStringHandling)
 	txt += getTopologyParentIsProxyStr(serverPlacement.IsLastCacheTier)
 	txt += getParentRetryStr(serverPlacement.IsLastCacheTier, atsMajorVer, dsParams.ParentRetry, dsParams.UnavailableServerRetryResponses, dsParams.MaxSimpleRetries, dsParams.MaxUnavailableServerRetries)
-	txt += " # topology '" + *ds.Topology + "'"
 	txt += "\n"
 	return txt, warnings, nil
 }

lib/go-atscfg/parentdotconfig_test.go

@@ -539,6 +539,10 @@ func TestMakeParentDotConfigTopologies(t *testing.T) {
 	if !strings.Contains(txt, "qstring=myQStringHandlingParam") {
 		t.Errorf("expected qstring from param 'qstring=myQStringHandlingParam', actual: '%v'", txt)
 	}
+	if strings.Contains(txt, "# topology") {
+		// ATS doesn't support inline comments in parent.config
+		t.Errorf("expected: no inline '# topology' comment, actual: '%v'", txt)
+	}
 }
 
 // TestMakeParentDotConfigNotInTopologies tests when a given edge is NOT in a Topology, that it doesn't add a remap line.